Re: Scala 2.12 End to End Tests

2021-08-26 Thread Danny Cranmer
I have raised the Jira [1]. If no one picks this up I will try to find some time next week to make a start. Thanks. [1] https://issues.apache.org/jira/browse/FLINK-23996 On Tue, Aug 24, 2021 at 11:37 AM Till Rohrmann wrote: > Great, thanks Danny. > > On Mon, Aug 23, 2021 at 9:41 PM Danny Cranm

Re: Scala 2.12 End to End Tests

2021-08-24 Thread Till Rohrmann
Great, thanks Danny. On Mon, Aug 23, 2021 at 9:41 PM Danny Cranmer wrote: > Thanks Till! > > +1 making Scala 2.12 the default. I will raise a Jira tomorrow, not at the > laptop today. > > On Mon, 23 Aug 2021, 09:43 Martijn Visser, wrote: > > > +1 to switch to 2.12 by default > > > > On Sat, 21

Re: Scala 2.12 End to End Tests

2021-08-23 Thread Danny Cranmer
Thanks Till! +1 making Scala 2.12 the default. I will raise a Jira tomorrow, not at the laptop today. On Mon, 23 Aug 2021, 09:43 Martijn Visser, wrote: > +1 to switch to 2.12 by default > > On Sat, 21 Aug 2021 at 13:43, Chesnay Schepler wrote: > > > I'm with Till that we should switch to 2.12

Re: Scala 2.12 End to End Tests

2021-08-23 Thread Martijn Visser
+1 to switch to 2.12 by default On Sat, 21 Aug 2021 at 13:43, Chesnay Schepler wrote: > I'm with Till that we should switch to 2.12 by default . > > On 21/08/2021 11:12, Till Rohrmann wrote: > > Hi Danny, > > > > I think in the nightly builds we do run the e2e with Scala 2.12 [1]. The > > way it

Re: Scala 2.12 End to End Tests

2021-08-21 Thread Chesnay Schepler
I'm with Till that we should switch to 2.12 by default . On 21/08/2021 11:12, Till Rohrmann wrote: Hi Danny, I think in the nightly builds we do run the e2e with Scala 2.12 [1]. The way it is configured is via the PROFILE env variable if I am not mistaken. Independent of this we might wanna st

Re: Scala 2.12 End to End Tests

2021-08-21 Thread Till Rohrmann
Hi Danny, I think in the nightly builds we do run the e2e with Scala 2.12 [1]. The way it is configured is via the PROFILE env variable if I am not mistaken. Independent of this we might wanna start a discussion whether we don't want to switch to Scala 2.12. per default. [1] https://dev.azure.co

Scala 2.12 End to End Tests

2021-08-20 Thread Danny Cranmer
Hello, I am working on reviewing a PR [1] to add JSON support for the AWS Glue Schema Registry integration. The module only builds for Scala 2.12 due to a dependency incompatibility. The end-to-end tests have been implemented using the newer Java framework rather than bash scripts. However, it app