What is the way to prove performance improvement?

Hi all, Recently I pull 3 PRs about performance improvements[1][2][3]. Unit tests will verify their correctness, and in the real scenario, we have benchmark report to confirm that they do help for performance. I wonder what is the formal way to verify a performance improvement. Is it to give out

Re: What is the way to prove performance improvement?

Hi Tison, at the moment there is formal way to verify performance improvements. What you can do is to provide your measurements by adding the graphs to the PR thread and specify the setup. Then others could try to verify these numbers by running their own benchmark. Cheers, Till On Wed, Jul 18,

Re: What is the way to prove performance improvement?

Hi Till, Thanks for your reply! I will try to add ones later. Best, tison. Till Rohrmann 于2018年7月18日周三 下午2:48写道： > Hi Tison, > > at the moment there is formal way to verify performance improvements. What > you can do is to provide your measurements by adding the graphs to the PR > thread and s

Re: What is the way to prove performance improvement?

Hi, There is a some small set of benchmarks defined in https://github.com/dataArtisans/flink-benchmarks , however their scope is limited and after briefly looking at your PRs, I wouldn’t expect them to cover your cases. However if you could de

Re: What is the way to prove performance improvement?

Hi Piotrek, Thanks for your reply! These improvements are inspired by some batch table tasks outside flink/master. Let me take a look at that you link to and see if I could define proper benchmark. Best, tison. Piotr Nowojski 于2018年7月18日周三 下午4:45写道： > Hi, > > There is a some small set of bench