Re: Including the streaming scala-api in the 0.8 release

2015-01-06 Thread Stephan Ewen
Good from my side! On Tue, Jan 6, 2015 at 10:58 AM, Márton Balassi wrote: > If no objections I'd like to merge the update during the afternoon. > > On Tue, Jan 6, 2015 at 12:32 AM, Márton Balassi > wrote: > > > Well, cherry-picking was a bit longer than expected, but is finally > ready. > > [1]

Re: Including the streaming scala-api in the 0.8 release

2015-01-06 Thread Márton Balassi
If no objections I'd like to merge the update during the afternoon. On Tue, Jan 6, 2015 at 12:32 AM, Márton Balassi wrote: > Well, cherry-picking was a bit longer than expected, but is finally ready. > [1] > > [1] https://github.com/apache/incubator-flink/pull/282 > > Best, > > Marton > > > On M

Re: Including the streaming scala-api in the 0.8 release

2015-01-05 Thread Márton Balassi
Well, cherry-picking was a bit longer than expected, but is finally ready. [1] [1] https://github.com/apache/incubator-flink/pull/282 Best, Marton On Mon, Jan 5, 2015 at 3:47 PM, Gyula Fóra wrote: > We don't have any tests for the scala api yet, because in 95% it just wraps > the java api, n

Re: Including the streaming scala-api in the 0.8 release

2015-01-05 Thread Gyula Fóra
We don't have any tests for the scala api yet, because in 95% it just wraps the java api, no new logic except for the aggregations which should have tests indeed. The api itself have proper docs we just didn't update the streaming-guide. But I think since the streaming api is still in a beta phase

Re: Including the streaming scala-api in the 0.8 release

2015-01-05 Thread Márton Balassi
+1 for the proposal. Cherry-pick: Can do, does not depend on the other big PR merged since the branch off (Till's). Assembling it in a moment. Marton On Mon, Jan 5, 2015 at 3:20 PM, Stephan Ewen wrote: > Can you cherry-pick it onto the 0.8 branch? > > If that works well and the main streaming a

Re: Including the streaming scala-api in the 0.8 release

2015-01-05 Thread Robert Metzger
Do we have any tests for the scala streaming API ? With tests and documentation missing there is very little time. I hope that we get the first release candidate out tomorrow. On Mon, Jan 5, 2015 at 3:33 PM, Gyula Fóra wrote: > Yes, we can cherry-pick it, thats not a problem. > > On Mon, Jan 5,

Re: Including the streaming scala-api in the 0.8 release

2015-01-05 Thread Gyula Fóra
Yes, we can cherry-pick it, thats not a problem. On Mon, Jan 5, 2015 at 3:20 PM, Stephan Ewen wrote: > Can you cherry-pick it onto the 0.8 branch? > > If that works well and the main streaming authors (Marton, Gyula, Paris, > Jonas, Gabor, ...) back that decision, I would go for it. > > On Mon,

Re: Including the streaming scala-api in the 0.8 release

2015-01-05 Thread Stephan Ewen
Can you cherry-pick it onto the 0.8 branch? If that works well and the main streaming authors (Marton, Gyula, Paris, Jonas, Gabor, ...) back that decision, I would go for it. On Mon, Jan 5, 2015 at 3:02 PM, Gyula Fóra wrote: > +1 > I agree to include it, the only thing missing there is the stre

Re: Including the streaming scala-api in the 0.8 release

2015-01-05 Thread Gyula Fóra
+1 I agree to include it, the only thing missing there is the streaming guide for scala. On Mon, Jan 5, 2015 at 2:49 PM, Paris Carbone wrote: > > Hello everyone! > > While the 0.8 release is on its way, I would suggest we also include the > latest streaming scala-api. It is fairly stable, at lea

Including the streaming scala-api in the 0.8 release

2015-01-05 Thread Paris Carbone
Hello everyone! While the 0.8 release is on its way, I would suggest we also include the latest streaming scala-api. It is fairly stable, at least as stable as the current java streaming api it builds on and it looks quite straightforward as well for new users. Given that the next release wi