Yes, please do include the statement to make asfgit close the PR.
We need to make good merge scripts for committer to help merging PRs from
github.
Sorry for late response, I am out of town with limited access to Internet.
- Henry
On Friday, June 13, 2014, Robert Metzger wrote:
> Ah, and read
And then Pat did some additions that somewhat messed up contributors' and
committers roles.
In initial edition, committers did not (and do not) have to fork
apache/ on github to be able to merge a PR. In fact, they don't even
have to have a github account in order to be able to the merge -- but th
@ssc Very nice, thanks for the source!
Dmitriy did a nice writeup for the new github integration of Mahout,
that could be helpful here:
https://mahout.apache.org/developers/github.html
--sebastian
On 06/13/2014 02:26 PM, Robert Metzger wrote:
Ah, and reading the emails from the bot also helps. It says:
To close this pull request,
Ah, and reading the emails from the bot also helps. It says:
To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #16
With the next pull request I'm merging, I'll close all pull requests we
want to be close
No, as Sean said, that there is a mechanism for the "asfgit" user that it
closes the pull request.
I'm not sure if it is parsing the commit messages, but the Spark commits
contain the following *additional* text (for example:)
Author: Henry Saputra
> Closes #1060 from hsaputra/cleanup_connection_c
Very often we manually merge/rebase pull requests, which gives the commits
different hashes.
In those cases, GitHub did not recognize pull requests as merged.
Does that mean that all those Pull requests will remain open?
The lingering pull requests are just backlog. I know that the asfgit
user can automatically close PRs too, since it does in Spark. I
remember it can't close PRs opened against branches other than master
though, and neither can committers / administrators. In fact I don't
think anyone except asfgit
On 13 Jun 2014, at 09:54, Robert Metzger wrote:
> If you look at Apache Spark (which is using the GitHub integration for
> quite some time now), it seems that they have exactly the situation you've
> described: A lot of lingering pull requests:
> https://github.com/apache/spark/pulls?direction=d
If you look at Apache Spark (which is using the GitHub integration for
quite some time now), it seems that they have exactly the situation you've
described: A lot of lingering pull requests:
https://github.com/apache/spark/pulls?direction=desc&page=8&sort=created&state=open
Github has support for s
10 matches
Mail list logo
