Re: [VOTE] Release Apache Flume version 1.3.0 rc5

2012-11-27 Thread Mike Percy
+1 for rc5 * Verified signatures checksums of both artifacts * Unit tests pass * Binary artifact runs, built source artifact runs * LICENSE, NOTICE, and CHANGELOG files look good * Did a diff -rq between the tag and the source artifact. Only missing a few dotfiles at the top level in the source

Re: [VOTE] Release Apache Flume version 1.3.0 rc5

2012-11-27 Thread Brock Noland
What dotfiles are you seeing as missing? I see .classpath, .project, and .settings but those are generated by maven and should not be included. I do see a missing .gitignore but I don't think that should be included as the tar ball is not managed by git. Brock On Tue, Nov 27, 2012 at 2:25 AM,

[jira] [Created] (FLUME-1740) Remove contrib/ directory from Flume NG

2012-11-27 Thread Mike Percy (JIRA)
Mike Percy created FLUME-1740: - Summary: Remove contrib/ directory from Flume NG Key: FLUME-1740 URL: https://issues.apache.org/jira/browse/FLUME-1740 Project: Flume Issue Type: Improvement

[jira] [Assigned] (FLUME-1740) Remove contrib/ directory from Flume NG

2012-11-27 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy reassigned FLUME-1740: - Assignee: Mike Percy Remove contrib/ directory from Flume NG

Re: [VOTE] Release Apache Flume version 1.3.0 rc5

2012-11-27 Thread Mike Percy
Hi Brock, This is the output I get from an unpacked pristine source tarball and a pristine (unbuilt) clone of the tag: [~/Downloads/flume-1.3.0-rc5/apache-flume-1.3.0-src] {mpercy@silverdoom}$ diff -rq . ~/src/flume.pristine Only in /Users/mpercy/src/flume.pristine: .git Only in

[jira] [Created] (FLUME-1741) ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around

2012-11-27 Thread Brock Noland (JIRA)
Brock Noland created FLUME-1741: --- Summary: ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around Key: FLUME-1741 URL: https://issues.apache.org/jira/browse/FLUME-1741 Project:

Re: [VOTE] Release Apache Flume version 1.3.0 rc5

2012-11-27 Thread Brock Noland
Hi, Yeah I don't think these issues require another RC. The elastic search directory thing should be resolved so the tests don't leave it around (https://issues.apache.org/jira/browse/FLUME-1741) and I do not have an opinion on the .gitignore file other than it is in no way required for a

Re: [VOTE] Release Apache Flume version 1.3.0 rc5

2012-11-27 Thread Roman Shaposhnik
On Wed, Nov 21, 2012 at 11:07 AM, Brock Noland br...@cloudera.com wrote: This is the second release for Apache Flume as a top-level project, version 1.3.0. We are voting on release candidate rc5. *** Please cast your vote within the next 72 hours *** The list of fixed issues:

[jira] [Created] (FLUME-1742) Mistake in code example in Flume Developer Guide, section Developing custom components/Source

2012-11-27 Thread Dmitry Kholodilov (JIRA)
Dmitry Kholodilov created FLUME-1742: Summary: Mistake in code example in Flume Developer Guide, section Developing custom components/Source Key: FLUME-1742 URL:

[jira] [Commented] (FLUME-1227) Introduce some sort of SpillableChannel

2012-11-27 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504893#comment-13504893 ] Roshan Naik commented on FLUME-1227: Thanks for those valuable thoughts Mike. I have

[jira] [Commented] (FLUME-1227) Introduce some sort of SpillableChannel

2012-11-27 Thread Brock Noland (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505021#comment-13505021 ] Brock Noland commented on FLUME-1227: - If we move forward with this proposal, I think

[jira] [Commented] (FLUME-1630) Flume configuration code could be improved

2012-11-27 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505033#comment-13505033 ] Hari Shreedharan commented on FLUME-1630: - Unfortunately my review is on rb, and

Re: Review Request: FLUME-1630: Flume configuration code could be improved

2012-11-27 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7518/#review13760 --- Looks good. I have some minor comments, many are really nits.

Re: Review Request: FLUME-1713 Netcat source to not return OK

2012-11-27 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8220/#review13797 --- Ship it! Looks good! Please make the following changes and then

Re: [VOTE] Release Apache Flume version 1.3.0 rc5

2012-11-27 Thread Roshan Naik
Multiport syslog tcp source problem .. Here is the config I am using... agent1.channels = memoryChannel agent1.channels.memoryChannel.type = memory agent1.sources = src0 agent1.sources.src0.type = multiport_syslogtcp # agent1.sources.src0.type = org.apache.flume.source.MultiportSyslogTCPSource

Re: Review Request: FLUME-1713 Netcat source to not return OK

2012-11-27 Thread Rahul Ravindran
On Nov. 28, 2012, 2:54 a.m., Mike Percy wrote: Looks good! Please make the following changes and then attach the patch to the JIRA: * Rename ackEveryEvent to ack-every-event to remain consistent with the existing elements. Even though we have agreed to make all new properties