Re: Review Request 50485: bug fix in Exec source

2016-08-24 Thread deng kai
> On 七月 27, 2016, 6:44 p.m., Mike Percy wrote: > > Hi Deng Kai, thank you for the patch. Could you please also write a test > > for this? No problem, it's my pleasure. - deng --- This is an automatically generated e-mail. To reply, vis

[jira] [Updated] (FLUME-2979) File descriptor leaks in TaildirSource

2016-08-24 Thread Kun Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kun Liu updated FLUME-2979: --- Description: TaildirSource creates ReliableTaildirEventReader object in start() method, and the constructor

[jira] [Created] (FLUME-2979) File descriptor leaks in TaildirSource

2016-08-24 Thread Kun Liu (JIRA)
Kun Liu created FLUME-2979: -- Summary: File descriptor leaks in TaildirSource Key: FLUME-2979 URL: https://issues.apache.org/jira/browse/FLUME-2979 Project: Flume Issue Type: Bug Components

[jira] [Created] (FLUME-2978) File descriptor leaks in TaildirSource

2016-08-24 Thread Kun Liu (JIRA)
Kun Liu created FLUME-2978: -- Summary: File descriptor leaks in TaildirSource Key: FLUME-2978 URL: https://issues.apache.org/jira/browse/FLUME-2978 Project: Flume Issue Type: Bug Components

Re: Review Request 51112: FLUME-2972: Handle offset migration in the new Kafka Channel

2016-08-24 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51112/ --- (Updated Aug. 24, 2016, 9:55 p.m.) Review request for Flume. Bugs: FLUME-2972

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-24 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Aug. 24, 2016, 9:08 p.m.) Review request for Flume. Bugs: FLUME-2171

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-24 Thread Balázs Donát Bessenyei
> On Aug. 24, 2016, 4:30 p.m., Attila Simon wrote: > > w/flume-ng-core/src/main/java/org/apache/flume/interceptor/RemoveHeaderInterceptor.java, > > lines 52-56 > > > > > > Have you considered moving these out to a >

Re: Review Request 51112: FLUME-2972: Handle offset migration in the new Kafka Channel

2016-08-24 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51112/#review146677 --- flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/fl

Re: Review Request 51112: FLUME-2972: Handle offset migration in the new Kafka Channel

2016-08-24 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51112/#review146580 --- I have concerns about this being safe. See especially my comments

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-24 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/#review146665 --- c/flume-ng-doc/sphinx/FlumeUserGuide.rst (lines 3474 - 3477)

[jira] [Comment Edited] (FLUME-2977) fix compile warnings from SAXParser

2016-08-24 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435009#comment-15435009 ] Attila Simon edited comment on FLUME-2977 at 8/24/16 2:23 PM: --

[jira] [Updated] (FLUME-2977) fix compile warnings from SAXParser

2016-08-24 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Simon updated FLUME-2977: Priority: Minor (was: Major) > fix compile warnings from SAXParser > --

[jira] [Updated] (FLUME-2977) fix compile warnings from SAXParser

2016-08-24 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Simon updated FLUME-2977: Attachment: FLUME-2977.patch > fix compile warnings from SAXParser > ---

[jira] [Commented] (FLUME-2977) fix compile warnings from SAXParser

2016-08-24 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435003#comment-15435003 ] Attila Simon commented on FLUME-2977: - Seems like it is related to RAT->Doxia->Xerces

[jira] [Created] (FLUME-2977) fix compile warnings from SAXParser

2016-08-24 Thread Attila Simon (JIRA)
Attila Simon created FLUME-2977: --- Summary: fix compile warnings from SAXParser Key: FLUME-2977 URL: https://issues.apache.org/jira/browse/FLUME-2977 Project: Flume Issue Type: Improvement

Re: Review Request 51182: FLUME-2954: make raw data appearing in log messages explicit

2016-08-24 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51182/#review146645 --- Ship it! Ship It! - Balázs Donát Bessenyei On Aug. 24, 2016,

Re: Review Request 51182: FLUME-2954: make raw data appearing in log messages explicit

2016-08-24 Thread Attila Simon
> On Aug. 24, 2016, 10:17 a.m., Balázs Donát Bessenyei wrote: > > flume-ng-doc/sphinx/FlumeUserGuide.rst, lines 246-247 > > > > > > nit: still a few spelling errors fixed > On Aug. 24, 2016, 10:17 a.m., Balázs Don

Re: Review Request 51182: FLUME-2954: make raw data appearing in log messages explicit

2016-08-24 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51182/ --- (Updated Aug. 24, 2016, 11:58 a.m.) Review request for Flume. Bugs: FLUME-295

Re: Review Request 51182: FLUME-2954: make raw data appearing in log messages explicit

2016-08-24 Thread Balázs Donát Bessenyei
> On Aug. 24, 2016, 10:17 a.m., Balázs Donát Bessenyei wrote: > > Otherwise, LGTM - Balázs Donát --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51182/#review146634 --

Re: Review Request 51182: FLUME-2954: make raw data appearing in log messages explicit

2016-08-24 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51182/#review146634 --- flume-ng-doc/sphinx/FlumeUserGuide.rst (lines 246 - 247)

Re: Review Request 51182: FLUME-2954: make raw data appearing in log messages explicit

2016-08-24 Thread Attila Simon
> On Aug. 17, 2016, 4:13 p.m., Balázs Donát Bessenyei wrote: > > flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/MorphlineSink.java, > > line 139 > > > > > > Can we jus

Re: Review Request 51182: FLUME-2954: make raw data appearing in log messages explicit

2016-08-24 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51182/ --- (Updated Aug. 24, 2016, 8:46 a.m.) Review request for Flume. Bugs: FLUME-2954