Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-11-14 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Nov. 14, 2016, 7:32 p.m.) Review request for Flume. Bugs:

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-11-14 Thread Balázs Donát Bessenyei
> On Nov. 14, 2016, 1:58 p.m., Jeff Holoman wrote: > > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 3928 > > > > > > Do you think you could add an example of a couple of common match > > patterns? Might be helpful

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-11-14 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/#review155805 --- Fix it, then Ship it!

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-11-14 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Nov. 14, 2016, 9:19 a.m.) Review request for Flume. Bugs:

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-10-19 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/#review153273 ---

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-10-19 Thread Attila Simon
> On Aug. 24, 2016, 4:30 p.m., Attila Simon wrote: > > w/flume-ng-core/src/main/java/org/apache/flume/interceptor/RemoveHeaderInterceptor.java, > > line 139 > > > > > > Please don't log out the whole Event for each

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-09-14 Thread Denes Arvay
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/#review148902 --- Ship it! Ship It! - Denes Arvay On Aug. 24, 2016, 9:08

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-24 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Aug. 24, 2016, 9:08 p.m.) Review request for Flume. Bugs:

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-24 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/#review146665 --- c/flume-ng-doc/sphinx/FlumeUserGuide.rst (lines 3474 - 3477)

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-23 Thread Balázs Donát Bessenyei
> On Aug. 23, 2016, 11:05 a.m., Denes Arvay wrote: > > flume-ng-core/src/main/java/org/apache/flume/interceptor/RemoveHeaderInterceptor.java, > > lines 63-65 > > > > > > why `protected`? `private` should work too.

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-23 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Aug. 23, 2016, 2:43 p.m.) Review request for Flume. Bugs:

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-23 Thread Denes Arvay
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/#review146503 ---

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-22 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Aug. 22, 2016, 11:13 p.m.) Review request for Flume. Changes

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-22 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Aug. 22, 2016, 11:10 p.m.) Review request for Flume. Changes

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-22 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Aug. 22, 2016, 10:51 p.m.) Review request for Flume. Changes

Re: Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-22 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- (Updated Aug. 22, 2016, 10:02 a.m.) Review request for Flume. Bugs:

Review Request 51244: FLUME-2171: Add Interceptor to remove headers from event

2016-08-19 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51244/ --- Review request for Flume. Repository: flume-git Description --- I found