[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72598874 --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala --- @@ -74,11 +74,10 @@ abstrac

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72588764 --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala --- @@ -92,6 +91,7 @@ abstract

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

Github user whjiang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72590179 --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala --- @@ -74,11 +74,10 @@ abstract

[GitHub] incubator-gearpump issue #67: fix GEARPUMP-32, introduce source watermark

Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/67 For an example of watermark usage, please refer to [KafkaWriter](https://github.com/manuzhang/incubator-gearpump/blob/watermark_example/examples/streaming/kafka/src/main/scala/org/apache/

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72599381 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala --- @@ -86,4 +90,30 @@ objec

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

Github user whjiang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72589692 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala --- @@ -86,4 +90,30 @@ object

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397448#comment-15397448 ] ASF GitHub Bot commented on GEARPUMP-32: Github user manuzhang commented on the i

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397368#comment-15397368 ] ASF GitHub Bot commented on GEARPUMP-32: Github user manuzhang commented on a dif

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397366#comment-15397366 ] ASF GitHub Bot commented on GEARPUMP-32: Github user manuzhang commented on a dif

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397304#comment-15397304 ] ASF GitHub Bot commented on GEARPUMP-32: Github user whjiang commented on a diff

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397301#comment-15397301 ] ASF GitHub Bot commented on GEARPUMP-32: Github user whjiang commented on a diff

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397298#comment-15397298 ] ASF GitHub Bot commented on GEARPUMP-32: Github user manuzhang commented on a dif