[GitHub] incubator-gearpump issue #247: [GEARPUMP-377] Add TwitterSource and examples

2018-05-07 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/247 +1 ---

[GitHub] incubator-gearpump issue #247: [GEARPUMP-377] Add TwitterSource and examples

2018-05-06 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/247 What will happen if the app has multiple source tasks? Will each task have the same output? ---

[GitHub] incubator-gearpump issue #244: [GEARPUMP-373] Don't create hbase configurati...

2018-04-29 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/244 +1 ---

[GitHub] incubator-gearpump issue #243: [GEARPUMP-339] Fix unknown tag parameter

2018-04-22 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/243 +1 ---

[GitHub] incubator-gearpump pull request #227: [GEARPUMP-350] Fix the not started app...

2018-04-03 Thread huafengw
Github user huafengw closed the pull request at: https://github.com/apache/incubator-gearpump/pull/227 ---

[GitHub] incubator-gearpump issue #240: [GEARPUMP-344] Fix broken links in README

2018-03-15 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/240 +1 ---

[GitHub] incubator-gearpump issue #239: [GEARPUMP-366] Create JarStore dir if not exi...

2018-03-15 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/239 +1 ---

[GitHub] incubator-gearpump issue #238: [GEARPUMP-350] Fix app clock not started

2018-03-14 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/238 +1 ---

[GitHub] incubator-gearpump issue #233: [GEARPUMP-361] Build gearpump docker image lo...

2017-12-09 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/233 +1 ---

[GitHub] incubator-gearpump pull request #236: [GEARPUMP-362] Fix bin/gear info shows...

2017-10-27 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/236 [GEARPUMP-362] Fix bin/gear info shows nothing when there are apps ru… …nning Be sure to do all of the following to help us incorporate your contribution quickly

[GitHub] incubator-gearpump issue #233: [GEARPUMP-361] Build gearpump docker image lo...

2017-10-27 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/233 1. I have to build with explicit proxies like `docker build --build-arg HTTP_PROXY=... --build-arg HTTPS_PROXY=...`. If not, building step `fetch http://dl

[GitHub] incubator-gearpump pull request #227: [GEARPUMP-350] Fix the not started app...

2017-10-26 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/227#discussion_r147065810 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala --- @@ -361,10 +358,11 @@ class TaskActor

[GitHub] incubator-gearpump pull request #234: [GEARPUMP-359] Fix OutputWatermark adv...

2017-10-26 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/234 [GEARPUMP-359] Fix OutputWatermark advancing logic in Subscription Be sure to do all of the following to help us incorporate your contribution quickly and easily

[GitHub] incubator-gearpump issue #233: [WIP] Fix integration test

2017-10-23 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/233 Verified on centos, the updated image can be launched successfully. ---

[GitHub] incubator-gearpump pull request #232: [GEARPUMP-358] Decrease the frequency ...

2017-10-18 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/232 [GEARPUMP-358] Decrease the frequency of watermark calculation Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make

[GitHub] incubator-gearpump issue #231: [GEARPUMP-355] Fix YarnAppMaster address reso...

2017-10-12 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/231 Hi @titikakatoo, thanks for your response. I'd like to know how you set up your cluster. I just got a single-node secured yarn cluster but found the command you posted goes well

[GitHub] incubator-gearpump issue #231: [GEARPUMP-355] Fix YarnAppMaster address reso...

2017-10-12 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/231 Hi @titikakatoo , thanks for your contribution! Can you briefly describe how to reproduce the problem you found? I'm setting up a secured cluster and try to verify your pull request

[GitHub] incubator-gearpump pull request #227: [GEARPUMP-350] Fix the not started app...

2017-09-29 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/227 [GEARPUMP-350] Fix the not started app clock Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit

[GitHub] incubator-gearpump issue #227: [GEARPUMP-350] Fix the not started app clock

2017-09-29 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/227 Verified streaming examples including complex dag, SOL, word count dsl and wordcount java. ---

[GitHub] incubator-gearpump pull request #226: [WIP] Don't use window runner for non-...

2017-09-28 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/226#discussion_r141637090 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala --- @@ -73,6 +73,25 @@ case class AndThen

[GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...

2017-09-18 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/223#discussion_r139345072 --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala --- @@ -318,12 +360,8 @@ class Graph[N, E](vertexList: List[N], edgeList

[GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...

2017-09-14 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/223#discussion_r138880775 --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala --- @@ -81,28 +86,35 @@ class Graph[N, E](vertexList: List[N], edgeList

[GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...

2017-09-14 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/223#discussion_r138881132 --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala --- @@ -243,13 +259,34 @@ class Graph[N, E](vertexList: List[N], edgeList

[GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...

2017-09-14 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/223#discussion_r138880939 --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala --- @@ -165,7 +181,7 @@ class Graph[N, E](vertexList: List[N], edgeList

[GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...

2017-09-14 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/223#discussion_r138882103 --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala --- @@ -355,19 +393,7 @@ class Graph[N, E](vertexList: List[N], edgeList

[GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...

2017-09-05 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/223 [GEARPUMP-349] Optimize Graph topologicalOrderIterator performance Be sure to do all of the following to help us incorporate your contribution quickly and easily

[GitHub] incubator-gearpump pull request #222: [GEARPUMP-348] Allow application total...

2017-09-01 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/222 [GEARPUMP-348] Allow application total number of retries to be config… …urable Be sure to do all of the following to help us incorporate your contribution quickly

[GitHub] incubator-gearpump issue #221: [GEARPUMP-217] Merge sql branch into master

2017-08-30 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/221 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #215: [GEARPUMP-343] Fix typo of EmbeddedRuntimeEnv...

2017-08-17 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/215 ``` The job exceeded the maximum time limit for jobs, and has been terminated. ``` --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-gearpump pull request #215: [GEARPUMP-343] Fix typo of EmbeddedRun...

2017-08-16 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/215 [GEARPUMP-343] Fix typo of EmbeddedRuntimeEnvironment Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure

[GitHub] incubator-gearpump issue #214: [GEARPUMP-341] Update processing watermark in...

2017-08-16 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/214 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #213: [GEARPUMP-339] Add ScalaDoc to window api and...

2017-08-13 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump pull request #213: [GEARPUMP-339] Add ScalaDoc to window ...

2017-08-13 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/213#discussion_r132863041 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala --- @@ -137,11 +156,14 @@ class

[GitHub] incubator-gearpump issue #213: [GEARPUMP-339] Add ScalaDoc to window api and...

2017-08-13 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 No unit test failed, so where does the failure come from? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-gearpump pull request #212: [GEARPUMP-339] Add ScalaDoc to Streami...

2017-08-06 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/212#discussion_r131545040 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/scalaapi/StreamApp.scala --- @@ -62,6 +62,17 @@ class StreamApp

[GitHub] incubator-gearpump issue #212: [GEARPUMP-339] Add ScalaDoc to Streaming DSL

2017-08-06 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/212 Generally LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-gearpump issue #210: [GEARPUMP-339] Fix unknown tag parameter

2017-08-05 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/210 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #208: [GEARPUMP-338] Improve time related types and...

2017-08-03 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/208 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #207: [GEARPUMP-336] Add scalac options and fix war...

2017-08-03 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/207 LGTM, is the failure related? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-gearpump issue #205: [GEARPUMP-335] Set kafka tests log level to E...

2017-08-02 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/205 Good, please go ahead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-gearpump issue #204: [GEARPUMP-334] Fix Java WordCount DSL example

2017-08-02 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/204 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #205: [GEARPUMP-335] Set kafka tests log level to W...

2017-08-02 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/205 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #203: [GEARPUMP-333] Fix examples assembling

2017-08-01 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/203 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #203: [GEARPUMP-333] Fix examples assembling

2017-08-01 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/203 It's a random failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-28 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r130015303 --- Diff: docs/contents/dev/dev-write-1st-app.md --- @@ -9,7 +9,7 @@ We'll use the classical [wordcount](https://github.com/apache/incubator

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-28 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r130030700 --- Diff: docs/contents/dev/dev-write-1st-app.md --- @@ -9,7 +9,7 @@ We'll use the classical [wordcount](https://github.com/apache/incubator

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications can ...

2017-07-27 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/202 [GEARPUMP-331] Allow applications can be ran in IDE Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure

[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/200 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #200: [GEARPUMP-330] Allow examples to run in `sbt ...

2017-07-25 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/200 Document update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-gearpump issue #197: [GEARPUMP-327] Put jarstore and logs under "g...

2017-07-20 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/197 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...

2017-07-20 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/196#discussion_r128453676 --- Diff: project/BuildExperiments.scala --- @@ -46,7 +46,8 @@ object BuildExperiments extends sbt.Build { "org.apache.h

[GitHub] incubator-gearpump issue #194: [GEARPUMP-325] Fix license issues

2017-07-16 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/194 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #193: Bump up version to 0.8.5-SNAPSHOT

2017-07-14 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/193 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #192: [GEARPUMP-320] Handle stashed messages after ...

2017-06-22 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/192 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123429407 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/StatefulTask.scala --- @@ -0,0 +1,179

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123429421 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/StatefulTask.scala --- @@ -0,0 +1,179

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123428717 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/StateSpecs.scala --- @@ -0,0 +1,208

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123428767 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/StateSpecs.scala --- @@ -0,0 +1,208

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123428739 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/StateSpecs.scala --- @@ -0,0 +1,208

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123428752 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/StateSpecs.scala --- @@ -0,0 +1,208

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123429442 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/StatefulTask.scala --- @@ -0,0 +1,179

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123430323 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/heap/HeapStateInternals.scala --- @@ -0,0 +1,316

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123429491 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/StatefulTask.scala --- @@ -0,0 +1,179

[GitHub] incubator-gearpump pull request #190: [Gearpump 311] refactor state manageme...

2017-06-22 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/190#discussion_r123430243 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/refactor/state/InMemoryGlobalStateInternals.scala --- @@ -0,0 +1,276

[GitHub] incubator-gearpump issue #189: [Gearpump 311] refactor state management

2017-06-21 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/189 Hi @yanghua , thanks for your contribution! This is a huge pull request so I think it would take a while to fully review this one, and also, can you give some description of this pull

[GitHub] incubator-gearpump issue #188: [GEARPUMP-318] Exclude maven-plugin-api depen...

2017-06-20 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/188 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump pull request #187: [GEARPUMP-317] Fix Task minClock

2017-06-18 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/187#discussion_r122588303 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala --- @@ -118,25 +126,34 @@ class

[GitHub] incubator-gearpump pull request #187: [GEARPUMP-317] Fix Task minClock

2017-06-18 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/187#discussion_r122588434 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala --- @@ -40,7 +41,7 @@ class Subscription

[GitHub] incubator-gearpump pull request #186: [GEARPUMP-316] Decouple groupBy from w...

2017-06-06 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/186#discussion_r120526897 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala --- @@ -32,35 +32,34 @@ object

[GitHub] incubator-gearpump issue #186: [GEARPUMP-316] Decouple groupBy from window

2017-06-06 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/186 First I got an irrelevant comment, there is a `org.apache.gearpump.streaming.dsl.partitioner.GroupByPartitioner`, which looks like in a wrong place. --- If your project is set up

[GitHub] incubator-gearpump pull request #186: [GEARPUMP-316] Decouple groupBy from w...

2017-06-06 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/186#discussion_r120526614 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/GroupByTask.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed

[GitHub] incubator-gearpump issue #185: [GEARPUMP-315] Add GlobalWindows and implemen...

2017-05-27 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/185 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #184: [GEARPUMP-308] Fix TransformTask output time

2017-05-18 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/184 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump pull request #183: [GEARPUMP-312] Add Message trait and D...

2017-05-18 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/183#discussion_r117160623 --- Diff: integrationtest/core/src/it/scala/org/apache/gearpump/integrationtest/checklist/DefaultMessageDeliverySpec.scala --- @@ -28,7 +28,7

[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...

2017-05-18 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/183 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...

2017-05-17 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/183 Document update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...

2017-05-17 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/183 Can we and should we add an apply function in trait Message's companion object which returns a `DefaultMessage`? --- If your project is set up for it, you can reply to this email

[GitHub] incubator-gearpump issue #182: [GEARPUMP-307] Fix TransformTask$Transform in...

2017-05-09 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/182 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #181: [GEARPUMP-305] Add Internals section to docs

2017-05-08 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/181 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump pull request #180: [GEARPUMP-303] add a RabbitMQ sink to ...

2017-05-07 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/180#discussion_r115162272 --- Diff: experiments/rabbitmq/src/test/scala/org/apache/gearpump/experimental/rabbitmq/RabbitmqSinkSpec.scala --- @@ -0,0 +1,53

[GitHub] incubator-gearpump pull request #180: [GEARPUMP-303] add a RabbitMQ sink to ...

2017-05-07 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/180#discussion_r115161088 --- Diff: experiments/rabbitmq/src/main/scala/org/apache/gearpump/experimental/rabbitmq/RMQSink.scala --- @@ -0,0 +1,182

[GitHub] incubator-gearpump issue #178: [GEARPUMP-303] add a RabbitMQ sink to integra...

2017-05-07 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/178 Hi @yanghua , maybe you can close this one now:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-gearpump pull request #178: [GEARPUMP-303] add a RabbitMQ sink to ...

2017-05-05 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/178#discussion_r114961959 --- Diff: external/rabbitmq/src/main/scala/org/apache/gearpump/external/rabbitmq/RMQSink.scala --- @@ -0,0 +1,177 @@ +/* + * Licensed

[GitHub] incubator-gearpump pull request #178: [GEARPUMP-303] add a RabbitMQ sink to ...

2017-05-05 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/178#discussion_r114962623 --- Diff: external/rabbitmq/README.md --- @@ -0,0 +1,21 @@ +# Gearpump RabbitMQ + +Gearpump integration for [RabbitMQ](https

[GitHub] incubator-gearpump pull request #178: [GEARPUMP-303] add a RabbitMQ sink to ...

2017-05-05 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/178#discussion_r114962293 --- Diff: external/rabbitmq/src/test/scala/org/apache/gearpump/external/rabbitmq/RabbitmqSinkSpec.scala --- @@ -0,0 +1,51

[GitHub] incubator-gearpump issue #174: [GEARPUMP-295] Fix the failure of getting sta...

2017-04-20 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/174 @manuzhang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-gearpump pull request #174: [GEARPUMP-295] Fix the failure of gett...

2017-04-14 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/174 [GEARPUMP-295] Fix the failure of getting stalling tasks from clock s… …ervice Be sure to do all of the following to help us incorporate your contribution quickly

[GitHub] incubator-gearpump issue #170: [GEARPUMP-291] Refactor TaskActor

2017-03-10 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/170 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...

2017-03-09 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/169 @manuzhang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...

2017-03-09 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/169 I'll refactor status implementation to simple state machine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...

2017-03-09 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/169 Test pass: https://travis-ci.org/huafengw/incubator-gearpump/builds/209307018 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-gearpump pull request #169: [GEARPUMP-285] fix false alarm of shut...

2017-03-09 Thread huafengw
GitHub user huafengw opened a pull request: https://github.com/apache/incubator-gearpump/pull/169 [GEARPUMP-285] fix false alarm of shutting down executor time out Be sure to do all of the following to help us incorporate your contribution quickly and easily

[GitHub] incubator-gearpump issue #165: [GEARPUMP-287] Trigger data process on waterm...

2017-03-02 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/165 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-gearpump issue #162: [GEARPUMP-281] Using new version of docker im...

2017-03-01 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/162 Hi Karol, would you mind do some code modification in org.apache.gearpump.integrationtest.Docker.scala, change the implementation of `getNetworkGateway` to ``` final def

[GitHub] incubator-gearpump issue #162: [GEARPUMP-281] Using new version of docker im...

2017-03-01 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/162 +1 Merging Thanks Karol! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-gearpump issue #158: [GEARPUMP-267] Changing docker image for Kafk...

2017-02-28 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/158 Hi Karol, this pull request includes the former GEARPUMP-236 and it's also covered by your another pr, so maybe we can close this one? --- If your project is set up for it, you can

[GitHub] incubator-gearpump pull request #162: [GEARPUMP-281] Using new version of do...

2017-02-28 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/162#discussion_r103382701 --- Diff: integrationtest/docker/README.md --- @@ -1,28 +1,23 @@ -# Gearpump Launcher Docker Image - -The image helps developer

[GitHub] incubator-gearpump pull request #162: [GEARPUMP-281] Using new version of do...

2017-02-28 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/162#discussion_r103382851 --- Diff: integrationtest/docker/java/README.md --- @@ -0,0 +1,18 @@ +A minimalistic Oracle JDK 8 container on top of busybox. + +We

[GitHub] incubator-gearpump pull request #162: [GEARPUMP-281] Using new version of do...

2017-02-28 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/162#discussion_r103385452 --- Diff: integrationtest/docker/kafka/README.md --- @@ -0,0 +1,89 @@ +Kafka in Docker +=== + +**This is a fork spotify/kafka

[GitHub] incubator-gearpump issue #161: [GEARPUMP-283] Return app exception to client

2017-02-27 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/161 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

  1   2   3   >