[Discuss] Stream sumByValue should be sumByKey

2016-06-25 Thread Darion Yaphet
Hi team : I found Stream's sumByValue in package io.gearpump.streaming.dsl which is add the two tuple's second value with the same key . It's seems named by sumByKey maybe better ? -- long is the way and hard that out of Hell leads up to light

Re: [Discuss] Stream sumByValue should be sumByKey

2016-06-25 Thread Manu Zhang
+1. Could you make a PR ? On Sat, Jun 25, 2016 at 8:55 PM Darion Yaphet wrote: > Hi team : > > I found Stream's sumByValue in package io.gearpump.streaming.dsl which is > add the two tuple's second value with the same key . > > It's seems named by sumByKey maybe better ? > > > -- > > long is the

Re: [Discuss] Stream sumByValue should be sumByKey

2016-06-26 Thread Darion Yaphet
Hi : I have create a issues at : https://issues.apache.org/jira/browse/GEARPUMP-166 github pull request : https://github.com/apache/incubator-gearpump/pull/51 2016-06-26 9:26 GMT+08:00 Manu Zhang : > +1. Could you make a PR ? > > On Sat, Jun 25, 2016 at 8:55 PM Darion Yaphet > wrote: > >> Hi t