[GitHub] incubator-gearpump issue #134: [GEARPUMP-265] remove AppMasterRuntimeInfo fr...

2017-01-22 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/134 @huafengw seems the changes not only relate to a simple removal. Could you rephrase your PR title ? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] incubator-gearpump issue #134: [GEARPUMP-265] remove AppMasterRuntimeInfo fr...

2017-01-18 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/134 @huafengw I don't see much benefits with these changes. Do you have further refactoring in plan ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-gearpump issue #134: [GEARPUMP-265] remove AppMasterRuntimeInfo fr...

2017-01-18 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/134 ## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/134?src=pr) is 70.31% (diff: 93.54%) > Merging [#134](https://codecov.io/gh/apache/incubator-gearpump/pu