[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-18 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 Maybe we'd better change the default runtime environment to `Remote` rather than `Embedded`. It's easy to forget to set it. @huafengw may have some comments on this. ---

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-19 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 The root cause of this issue is that apps submitted from UI via `AppSubmitter` or `GearpumpStormClient` are run in the default `EmbeddedRuntimeEnvironment`. Currently, there

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-23 Thread karol-brejna-i
Github user karol-brejna-i commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 One more thing to discuss: In yarn code we already have a trait named `Command`: experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/appmaster/Command.

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-23 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 Actually, those requiring `RemoteRuntimeEnvironment` are commands that interact with `Master`. So how about `MasterClientCommand` ? This also solves your second question. ---

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-23 Thread karol-brejna-i
Github user karol-brejna-i commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 I did the initial version. Will test today. ---

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-23 Thread karol-brejna-i
Github user karol-brejna-i commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 I did search for AkkaApp usages and there are few groups of them: 1. examples (proper AkkaApp usage) 2. gearpupm-core (comands like submit, kill, etc. plus master and worker)

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-23 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 Note that `GearpumpNimbus` also falls into this group ---

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-27 Thread karol-brejna-i
Github user karol-brejna-i commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 Some IT tests failing. Trying to investigate. ---

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-29 Thread karol-brejna-i
Github user karol-brejna-i commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 @manuzhang Please, take a look. ---

[GitHub] incubator-gearpump issue #241: [WiP][GEARPUMP-368] Restore setting runtime e...

2018-04-29 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/241 LGTM +1 ---