Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
Maybe we'd better change the default runtime environment to `Remote` rather
than `Embedded`. It's easy to forget to set it.
@huafengw may have some comments on this.
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
The root cause of this issue is that apps submitted from UI via
`AppSubmitter` or `GearpumpStormClient` are run in the default
`EmbeddedRuntimeEnvironment`.
Currently, there
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
One more thing to discuss:
In yarn code we already have a trait named `Command`:
experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/appmaster/Command.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
Actually, those requiring `RemoteRuntimeEnvironment` are commands that
interact with `Master`. So how about `MasterClientCommand` ? This also solves
your second question.
---
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
I did the initial version. Will test today.
---
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
I did search for AkkaApp usages and there are few groups of them:
1. examples (proper AkkaApp usage)
2. gearpupm-core (comands like submit, kill, etc. plus master and worker)
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
Note that `GearpumpNimbus` also falls into this group
---
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
Some IT tests failing. Trying to investigate.
---
Github user karol-brejna-i commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
@manuzhang Please, take a look.
---
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/241
LGTM +1
---
10 matches
Mail list logo