Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/25#issuecomment-222634297
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/25#issuecomment-222614486
UT failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user manuzhang commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/25#issuecomment-222407072
I've verified related integration tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/25#discussion_r64866016
--- Diff:
external/kafka/src/main/java/org/apache/gearpump/streaming/kafka/KafkaSource.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/25#discussion_r64865492
--- Diff:
examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala
---
@@ -60,14 +64,19 @@ objec
Github user codecov-io commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/25#issuecomment-222076849
## [Current coverage][cc-pull] is **63.75%**
> Merging [#25][cc-pull] into [master][cc-base-branch] will increase
coverage by **1.97%**
1. 5 fi
Github user huafengw commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/25#issuecomment-222075106
Documentation update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user manuzhang commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/25#issuecomment-222076186
may I update doc as follow-up ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user manuzhang commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/25#issuecomment-222085353
please do not merge. I need to verify whether integration test passes
---
If your project is set up for it, you can reply to this email and have your
reply
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/25#discussion_r64865818
--- Diff:
examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala
---
@@ -60,14 +64,19 @@ obje
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/25#discussion_r64864833
--- Diff:
external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala
---
@@ -0,0 +1,173 @@
+/*
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/25#discussion_r64864436
--- Diff:
external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala
---
@@ -0,0 +1,173 @@
+/*
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/25#discussion_r64864167
--- Diff:
external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala
---
@@ -0,0 +1,173 @@
+/*
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/25
fix GEARPUMP-122, refactor kafka connector API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump kafka
15 matches
Mail list logo
