[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-28 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r130015303 --- Diff: docs/contents/dev/dev-write-1st-app.md --- @@ -9,7 +9,7 @@ We'll use the classical [wordcount](https://github.com/apache/incubator-gea

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-28 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r130016790 --- Diff: docs/contents/dev/dev-write-1st-app.md --- @@ -9,7 +9,7 @@ We'll use the classical [wordcount](https://github.com/apache/incubator-ge

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-28 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r130017080 --- Diff: core/src/main/scala/org/apache/gearpump/cluster/embedded/LocalRuntimeEnvironemnt.scala --- @@ -0,0 +1,43 @@ +/* + * Licensed

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-28 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r130016858 --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/RuntimeEnvironment.scala --- @@ -0,0 +1,44 @@ +/* + * Licensed to the

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-28 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r130030700 --- Diff: docs/contents/dev/dev-write-1st-app.md --- @@ -9,7 +9,7 @@ We'll use the classical [wordcount](https://github.com/apache/incubator-gea

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-27 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r129772729 --- Diff: examples/streaming/wordcount/src/main/scala/org/apache/gearpump/streaming/examples/wordcount/WordCount.scala --- @@ -64,18 +64,13 @@

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-27 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r129773363 --- Diff: docs/contents/dev/dev-write-1st-app.md --- @@ -9,7 +9,7 @@ We'll use the classical [wordcount](https://github.com/apache/incubator-ge

[GitHub] incubator-gearpump pull request #202: [GEARPUMP-331] Allow applications to b...

2017-07-27 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/202#discussion_r129772131 --- Diff: core/src/main/scala/org/apache/gearpump/cluster/embedded/EmbeddedCluster.scala --- @@ -36,27 +36,21 @@ import org.apache.gearpump.ut