[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-08-21 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r75613138 --- Diff: examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/NumberGeneratorProcessor.scala --- @@ -3

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-08-21 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r75612603 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala --- @@ -322,11 +305,45 @@ class TaskActor( private de

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-08-21 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r75612765 --- Diff: examples/streaming/fsio/src/main/scala/org/apache/gearpump/streaming/examples/fsio/SeqFileStreamProducer.scala --- @@ -64,6 +65,6 @@ cl

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-28 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72598874 --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala --- @@ -74,11 +74,10 @@ abstrac

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-28 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72588764 --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala --- @@ -92,6 +91,7 @@ abstract

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-28 Thread whjiang
Github user whjiang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72590179 --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala --- @@ -74,11 +74,10 @@ abstract

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-28 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72599381 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala --- @@ -86,4 +90,30 @@ objec

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-28 Thread whjiang
Github user whjiang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72589692 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala --- @@ -86,4 +90,30 @@ object

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72433772 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala --- @@ -86,4 +90,30 @@ objec

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72413816 --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala --- @@ -92,6 +91,7 @@ abstract c

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72412991 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala --- @@ -86,4 +90,30 @@ object

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72413298 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/*

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72412383 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/source/DataSourceTask.scala --- @@ -46,23 +46,39 @@ class DataSourceTask private

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread manuzhang
GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/67 fix GEARPUMP-32, introduce source watermark This is for early review and contains some example codes which will be removed before merge. You can merge this pull request into a Git rep