Github user gesterzhou commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90173276
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteFunctionNoAckOp.java
---
@@ -236,4 +236,16 @@ protected Message
Github user gesterzhou commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90173264
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -0,0 +1,164 @@
+/*
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54184/#review157355
---
Ship it!
Ship It!
- Dan Smith
On Nov. 29, 2016, 10:43 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54184/
---
Review request for geode, Barry Oglesby and Dan Smith.
Repository: geode
Desc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54003/#review157338
---
Ship it!
Ship It!
- Udo Kohlmeyer
On Nov. 29, 2016, 9:12 p.m
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/294#discussion_r90124555
--- Diff:
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java
---
@@ -45,7 +45,9 @@ private void t
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/296#discussion_r90118721
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/FederatingManager.java
---
@@ -386,7 +398,7 @@ public void startMana
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90116715
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -0,0 +1,164 @@
+/*
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54003/
---
(Updated Nov. 29, 2016, 9:12 p.m.)
Review request for geode, Galen O'Sullivan,
Github user vectorijk commented on the issue:
https://github.com/apache/incubator-geode/pull/300
@jhuynh1 @markito Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90078053
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -138,8 +127,8 @@ public void allocate
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90077733
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -50,36 +50,26 @@ public StatMonitorHa
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90077848
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -50,36 +50,26 @@ public StatMonitorHa
Github user markito commented on the issue:
https://github.com/apache/incubator-geode/pull/300
@vectorijk good catch! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90072798
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -0,0 +1,164 @@
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90073132
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -0,0 +1,164 @@
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90070586
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteFunctionNoAckOp.java
---
@@ -236,4 +236,16 @@ protected Mes
Github user jhuynh1 commented on the issue:
https://github.com/apache/incubator-geode/pull/300
The changes look good, I've merged them in.
Thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/292
+1 I think this should save 16 bytes per entry. The changes look good to
me! I'll merge them.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/290
I'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/290
@metatype Yes, precheckin ran clean.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user metatype commented on the issue:
https://github.com/apache/incubator-geode/pull/290
@kjduling Is this ready to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025325
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsMonitor.java
---
@@ -29,23 +29,20 @@
private final O
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025623
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsMonitor.java
---
@@ -114,14 +100,14 @@ protected void monitor(lon
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025856
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -228,7 +222,7 @@ private void work() {
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025338
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsMonitor.java
---
@@ -29,23 +29,20 @@
private final O
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90026482
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsMonitor.java
---
@@ -114,14 +100,14 @@ protected void monitor(lon
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025760
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -110,7 +100,7 @@ public void sampled(long na
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025277
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -38,7 +37,8 @@
private final boolean
Github user vectorijk commented on the issue:
https://github.com/apache/incubator-geode/pull/300
cc @markito
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
GitHub user vectorijk opened a pull request:
https://github.com/apache/incubator-geode/pull/300
[GEODE-224] Geode Spark connector parser is not processing type casting
properly
This issue is related to wrong regex of query string.
You can merge this pull request into a Git reposit
Github user davinash closed the pull request at:
https://github.com/apache/incubator-geode/pull/283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
closing the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/299
[ GEODE-2141 ] #comment Fix Issue #2141
Replaced List with ConcurrentHashSet
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/i
37 matches
Mail list logo
