[GitHub] incubator-geode issue #299: [ GEODE-2141 ] #comment Fix Issue #2141

Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/299 Thanks @upthewaterspout , @metatype for review I Have address review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Build failed in Jenkins: Geode-nightly #669

See Changes: [adongre] GEODE-1122: Replace environment variable "GEMFIRE" with "GEODE_HOME" [jiliao] GEODE-2092 - Security examples should not be in the product code [upthewaterspout] GEODE-1509: replacing HashSet of recipient gateways

Re: Review Request 53685: GEODE-1955: properly disconnect gfsh session so that it won't leave heartbeat thread around to pollute other tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53685/#review157416 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 28, 2016, 11:27 p.

[GitHub] incubator-geode issue #296: GEODE-2109 : Calling submit on ExecutionService ...

Github user deepakddixit commented on the issue: https://github.com/apache/incubator-geode/pull/296 @upthewaterspout Thanks for the review. The class declaration is mistakenly changed. I have corrected it. All tests are passing from precheckin after this. --- If your project is set u

Review Request 54209: GEODE-1931: CI Failure: LocatorUDPSecurityDUnitTest.testStartTwoLocators

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54209/ --- Review request for geode, Bruce Schuchardt and Hitesh Khamesra. Repository: geo

Re: Review Request 54003: GEODE-2137 client membership IDs contain 17 bytes of useless information that should be removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54003/#review157429 --- Ship it! Ship It! - Hitesh Khamesra On Nov. 29, 2016, 9:12 p

Review Request 54210: GEODE-2146: deploy should require more elevated privileges than just data:manage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54210/ --- Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. Repositor

Re: The next release (v1.1.0)

FYI, I started work on GEODE-2156 to remove references to “incubating”. Feel free to jump in on the feature branch (feature/GEODE-2156). I don’t plan to merge this to develop until the infrastructure changes are ready (see INFRA-12937). Anthony > On Nov 25, 2016, at 7:44 PM, Nitin Lamba wro

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90295325 --- Diff: geode-core/src/main/java/org/apache/geode/cache/client/internal/ExplicitConnectionSourceImpl.java --- @@ -257,7 +257,7 @@ public String

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90296214 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -92,22 +90,23 @@ public

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90296464 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -117,22 +116,19 @@ publ

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90296684 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -92,22 +90,23 @@ public

Re: Review Request 54209: GEODE-1931: CI Failure: LocatorUDPSecurityDUnitTest.testStartTwoLocators

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54209/#review157432 --- Ship it! I don't see anything wrong here - lots of improvements

Review Request 54225: GEODE-2157: Adding a serialVersionUID to PutAllPartialResultException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54225/ --- Review request for geode and Bruce Schuchardt. Repository: geode Description

Re: Review Request 54225: GEODE-2157: Adding a serialVersionUID to PutAllPartialResultException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54225/#review157464 --- Ship it! Ship It! - Bruce Schuchardt On Nov. 30, 2016, 8:09

Re: Review Request 54184: Adding a test to show secondary queue is being drained for GEODE-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54184/ --- (Updated Nov. 30, 2016, 9:18 p.m.) Review request for geode, Barry Oglesby and

Re: Review Request 54210: GEODE-2146: deploy should require more elevated privileges than just data:manage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54210/ --- (Updated Nov. 30, 2016, 9:27 p.m.) Review request for geode, Jared Stewart, Kev

Review Request 54230: Docs: Remove / convert some mentions of GemFire - Cluster config tutorial and Managing a Remote Cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54230/ --- Review request for geode, Joey McAllister and Karen Miller. Repository: geode

Review Request 54234: GEODE-2158: Include correct NOTICE file in jar artifacts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54234/ --- Review request for geode, Dick Cavender and Dan Smith. Repository: geode Desc

Review Request 54235: GEODE-2159 add serialVersionUIDs to exception classes not having them

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54235/ --- Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.

Re: Review Request 54234: GEODE-2158: Include correct NOTICE file in jar artifacts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54234/#review157499 --- Ship it! So simple but painful... - Dick Cavender On Nov. 30

Re: Review Request 54234: GEODE-2158: Include correct NOTICE file in jar artifacts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54234/#review157500 --- Ship it! Ship It! - Dan Smith On Nov. 30, 2016, 11:11 p.m.,

Re: Review Request 54230: Docs: Remove / convert some mentions of GemFire - Cluster config tutorial and Managing a Remote Cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54230/#review157516 --- Ship it! Ship It! - Joey McAllister On Nov. 30, 2016, 9:57 p

Re: Review Request 54230: Docs: Remove / convert some mentions of GemFire - Cluster config tutorial and Managing a Remote Cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54230/ --- (Updated Dec. 1, 2016, 12:48 a.m.) Review request for geode, Joey McAllister an

Re: Review Request 54230: Docs: Remove / convert some mentions of GemFire - Cluster config tutorial and Managing a Remote Cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54230/#review157524 --- Ship it! Ship It! - Karen Miller On Dec. 1, 2016, 12:48 a.m.

Review Request 54240: hdos.toByteArray() is unneeded

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54240/ --- Review request for geode and Dan Smith. Bugs: GEODE-2161 https://issues.apa

[GitHub] incubator-geode issue #299: [ GEODE-2141 ] #comment Fix Issue #2141

Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/299 Is this PR good to merge to develop ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] incubator-geode issue #293: GEODE-1653: Executing a fire-and-forget function...

Github user gesterzhou commented on the issue: https://github.com/apache/incubator-geode/pull/293 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if