Re: Review Request 60125: GEODE-3062: replace SecurityService after loading cluster config [FIXED]

2017-06-15 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60125/#review178082 --- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireC

Re: Review Request 60142: GEODE-3071: Provide capability to parallelize distributedTests

2017-06-15 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60142/#review178075 --- Thank you Jens! This is awesome. - Jared Stewart On June 16, 2

Re: Review Request 60142: GEODE-3071: Provide capability to parallelize distributedTests

2017-06-15 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60142/#review178070 --- So much awesome. - Anthony Baker On June 16, 2017, 12:59 a.m.,

Review Request 60142: GEODE-3071: Provide capability to parallelize distributedTests

2017-06-15 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60142/ --- Review request for geode, Anthony Baker, Mark Bretl, and Dan Smith. Repository:

[GitHub] geode issue #584: GEODE-2901: Adding integration tests of session replicatio...

2017-06-15 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/584 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] geode pull request #584: GEODE-2901: Adding integration tests of session rep...

2017-06-15 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/584 GEODE-2901: Adding integration tests of session replication Adding integration tests that test both session replications frameworks shipped with geode. These tests use cargo to download an

Re: Review Request 60125: GEODE-3062: replace SecurityService after loading cluster config [FIXED]

2017-06-15 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60125/#review178065 --- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireC

[GitHub] geode pull request #582: GEODE-2601: Fix banner being logged twice

2017-06-15 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/582#discussion_r122332971 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java --- @@ -469,15 +470,13 @@ private InternalLocator(int port, F

[GitHub] geode pull request #582: GEODE-2601: Fix banner being logged twice

2017-06-15 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/582#discussion_r122332566 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java --- @@ -2167,7 +2191,7 @@ private static void noti

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #586 was SUCCESSFUL (with 1868 tests)

2017-06-15 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #586 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-586/ -- This

[GitHub] geode pull request #583: GEODE-2854: GEODE REST API Docs Missing Authenticat...

2017-06-15 Thread karensmolermiller
Github user karensmolermiller commented on a diff in the pull request: https://github.com/apache/geode/pull/583#discussion_r122326144 --- Diff: geode-docs/rest_apps/setup_config.html.md.erb --- @@ -29,162 +31,233 @@ All Geode REST interface classes and required JAR files are distri

Review Request 60125: GEODE-3062: replace SecurityService after loading cluster config [FIXED]

2017-06-15 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60125/ --- Review request for geode, Emily Yeh, Jinmei Liao, Ken Howe, and Patrick Rhomberg

[GitHub] geode pull request #583: GEODE-2854: GEODE REST API Docs Missing Authenticat...

2017-06-15 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/583#discussion_r122319962 --- Diff: geode-docs/rest_apps/setup_config.html.md.erb --- @@ -29,162 +31,233 @@ All Geode REST interface classes and required JAR files are distribut

[GitHub] geode pull request #583: GEODE-2854: GEODE REST API Docs Missing Authenticat...

2017-06-15 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/583#discussion_r122320206 --- Diff: geode-docs/rest_apps/setup_config.html.md.erb --- @@ -29,162 +31,233 @@ All Geode REST interface classes and required JAR files are distribut

[GitHub] geode pull request #583: GEODE-2854: GEODE REST API Docs Missing Authenticat...

2017-06-15 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/583#discussion_r122320074 --- Diff: geode-docs/rest_apps/setup_config.html.md.erb --- @@ -29,162 +31,233 @@ All Geode REST interface classes and required JAR files are distribut

[GitHub] geode pull request #583: GEODE-2854: GEODE REST API Docs Missing Authenticat...

2017-06-15 Thread davebarnes97
GitHub user davebarnes97 opened a pull request: https://github.com/apache/geode/pull/583 GEODE-2854: GEODE REST API Docs Missing Authentication Reviews requested from: @mmartell, @jaredjstewart @karensmolermiller @joeymcallister You can merge this pull request into a Git repositor

[GitHub] geode pull request #582: GEODE-2601: Fix banner being logged twice

2017-06-15 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/582 GEODE-2601: Fix banner being logged twice [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2601) The banner (see `Banner.java`) was being logged twice every time a l

[GitHub] geode pull request #578: GEODE-1958: Removing/deprecating PasswordUtil

2017-06-15 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/578#discussion_r122279107 --- Diff: geode-core/src/test/java/org/apache/geode/cache/util/PasswordUtilJUnitTest.java --- @@ -1,42 +0,0 @@ -/* - * Licensed to the Apache Softwa

[GitHub] geode pull request #581: GEODE-2301 Doc note to deprecate Geode JTA trans mg...

2017-06-15 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/581 GEODE-2301 Doc note to deprecate Geode JTA trans mgr Simple addition to the beginning of the documentation of the Geode JTA transaction manager that the Geode JTA transaction manager is dep

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-15 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 15, 2017, 3:23 p.m.) Review request for geode, Emily Yeh, Jared S

Jenkins build is back to normal : Geode-release-flaky #15

2017-06-15 Thread Apache Jenkins Server
See

Build failed in Jenkins: Geode-release #64

2017-06-15 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-2294: revert to avoid rest protocol change [abaker] Update LICENSE after review [abaker] GEODE-3024 race condition between server locator preparing membership [abaker] GEODE-3024 race co