[GitHub] geode pull request #648: GEODE-3206 : Corrected order of lucene search resul...

2017-07-19 Thread deepakddixit
GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/648 GEODE-3206 : Corrected order of lucene search results based on score. * Lucene results with higher score value are more relevant than lower once. Used descending comparator for lucene

Jenkins build is back to normal : Geode-nightly-flaky #70

2017-07-19 Thread Apache Jenkins Server
See

Build failed in Jenkins: Geode-nightly #901

2017-07-19 Thread Apache Jenkins Server
See Changes: [emilyyeh1997] GEODE-2601: Made banner and configs log only once and added a test to [khowe] GEODE-2920: added security tests for create diskstore and create [khowe] GEODE-2189 Docs: Update Swagger

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

2017-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/645 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #647: GEODE-3271: Refactor WanCommands

2017-07-19 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/647 GEODE-3271: Refactor WanCommands [See the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3271) `WanCommands.java` was a large class that contained multiple commands. Each

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #621 was SUCCESSFUL (with 1979 tests). Change made by John Blum.

2017-07-19 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #621 was successful. --- Scheduled with changes by John Blum. 1981 tests in total.

[GitHub] geode issue #404: Geode 2469

2017-07-19 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/404 At this point this PR is a bit out of date. To merge, all of the .class, .pdf, .fig, etc. files would need to be removed, the merge fix done and whatever other cleanup is necessary. It also

[GitHub] geode issue #646: GEODE-3213: Refactor ProtoBuf handler flow

2017-07-19 Thread pivotal-amurmann
Github user pivotal-amurmann commented on the issue: https://github.com/apache/geode/pull/646 @kohlmu-pivotal @WireBaron @hiteshk25 @galen-pivotal @bschuchardt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

2017-07-19 Thread upthewaterspout
Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/645#discussion_r128376504 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARQAddOperationJUnitTest.java --- @@ -287,12 +289,11 @@ public void

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

2017-07-19 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/645 GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts * Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to checking expiration @upthewaterspout

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

2017-07-19 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/#review180980 --- Ship it! Ship It! - Jinmei Liao On July 19, 2017, 9:06

Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

2017-07-19 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

2017-07-19 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60974/#review180975 --- Ship it! Ship It! - Jared Stewart On July 19, 2017, 7:37

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

2017-07-19 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/598#discussion_r128363171 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/OptionAliasesIntegrationTest.java --- @@ -0,0 +1,259 @@ +/*

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

2017-07-19 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/598#discussion_r128362946 --- Diff: geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java --- @@ -26,6 +26,8 @@ import java.util.function.Predicate;

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

2017-07-19 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/598#discussion_r128362904 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java --- @@ -14,6 +14,8 @@ */

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

2017-07-19 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/598#discussion_r128354422 --- Diff: geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java --- @@ -26,6 +26,8 @@ import java.util.function.Predicate;

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

2017-07-19 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/598#discussion_r128354651 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/OptionAliasesIntegrationTest.java --- @@ -0,0 +1,259 @@ +/*

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

2017-07-19 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/598#discussion_r128354400 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java --- @@ -14,6 +14,8 @@ */

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

2017-07-19 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60974/ --- (Updated July 19, 2017, 7:37 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 60977: GEODE-3251: make JMX test rules more robust

2017-07-19 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60977/#review180959 --- Ship it! Ship It! - Ken Howe On July 19, 2017, 5:14 p.m.,

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

2017-07-19 Thread davebarnes97
Github user davebarnes97 commented on a diff in the pull request: https://github.com/apache/geode/pull/644#discussion_r128331252 --- Diff: geode-docs/tools_modules/gfsh/configuring_gfsh.html.md.erb --- @@ -24,13 +24,13 @@ The `gfsh.bat` and `gfsh` bash script automatically append

[GitHub] geode issue #590: GEODE-3090: Fixing gfsh help message (and a lot of other t...

2017-07-19 Thread jinmeiliao
Github user jinmeiliao commented on the issue: https://github.com/apache/geode/pull/590 pulling this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

2017-07-19 Thread joeymcallister
Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/geode/pull/644#discussion_r128320777 --- Diff: geode-docs/tools_modules/gfsh/configuring_gfsh.html.md.erb --- @@ -24,13 +24,13 @@ The `gfsh.bat` and `gfsh` bash script automatically

[GitHub] geode pull request #557: add GfshParserRule to facilitate command unit test

2017-07-19 Thread jinmeiliao
Github user jinmeiliao closed the pull request at: https://github.com/apache/geode/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #604: GEODE-2919: fix lucene security tests

2017-07-19 Thread jinmeiliao
Github user jinmeiliao closed the pull request at: https://github.com/apache/geode/pull/604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

2017-07-19 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/644 GEODE-3208 Revise docs with outdated JAR references @joeymcallister @davebarnes97 @kirklund Please review. Note: While making modifications to satisfy GEODE-3208, I took the

[GitHub] geode-examples pull request #11: GEODE-3233 Prefix distribution files with a...

2017-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-examples/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #592: GEODE-2707: Removing TXLockToken

2017-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 60977: GEODE-3251: make JMX test rules more robust

2017-07-19 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60977/#review180950 --- Ship it! Ship It! - Jared Stewart On July 19, 2017, 5:14

Re: RMIServer stub failures

2017-07-19 Thread Kirk Lund
It's a bit of a hack but I submitted https://reviews.apache.org/r/60977/ Something in the JMX RMI startup seems to be asynchronous, so our JMX junit rules "await" this startup before letting the test start. I added a check for "Failed to retrieve RMIServer stub" to this await step. If anyone has

Re: Review Request 60977: GEODE-3251: make JMX test rules more robust

2017-07-19 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60977/#review180949 --- Ship it! Ship It! - Jinmei Liao On July 19, 2017, 5:14

Review Request 60977: GEODE-3251: make JMX test rules more robust

2017-07-19 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60977/ --- Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and

RMIServer stub failures

2017-07-19 Thread Kirk Lund
Any ideas what to do with RMIServer stub failures in tests? This seems to be something going wrong in the JDK code that's outside of our control. Moving these JMX tests to FlakyTest category will have no effect. We'll simply have all JMX tests in FlakyTest instead of IntegrationTest. I can't see a

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

2017-07-19 Thread Jinmei Liao
> On July 19, 2017, 4:49 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Line 92 (original), 96 (patched) > > > > > > I think that having

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

2017-07-19 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60974/#review180943 ---

Re: Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.

2017-07-19 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60924/#review180938 --- Ship it! +1 - Kirk Lund On July 17, 2017, 9:39 p.m., Jinmei

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

2017-07-19 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60974/#review180937 --- Ship it! +1 - Kirk Lund On July 19, 2017, 4:06 p.m., Jinmei

Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

2017-07-19 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60974/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: Stored procedures on Apache Geode.

2017-07-19 Thread John Blum
Hi Marios- Regarding... *> Do you think this indeed will have a huge impact on the performance?* There are many factors that affect performance. A few things to consider might be... 1. How well you planned and organized the data (e.g. partitioning strategy, possible collocation). 2. How large

RE: Geode-Native Windows build

2017-07-19 Thread Daniel Farcovich
Hi Jacob, I can confirm that build passed on VS2017 using generator "Visual Studio 15 2017 Win64". Thanks, Daniel -Original Message- From: Jacob Barrett [mailto:jbarr...@pivotal.io] Sent: Thursday, July 13, 2017 4:20 PM To: dev@geode.apache.org Subject: Re: Geode-Native Windows build