Re: Gitbox enables the full GitHub workflow

Good to know!! The problem for Github issues is that the id is not continuous(the id space is shared with Github's issues and pull requests) which is not a good design IMO. Hong 2017-08-08 10:01 GMT+08:00 Lei Chang : > cool. this will simplify the commit workflow a lot.

Re: Gitbox enables the full GitHub workflow

cool. this will simplify the commit workflow a lot. And if we can use github issues instead of apache JIRA, that will be more convenient. Cheers Lei On Tue, Aug 8, 2017 at 9:09 AM, Roman Shaposhnik wrote: > Hi! > > it has just come to my attention that Gitbox at ASF >

Re: Gitbox enables the full GitHub workflow

+1 for Gitbox This will greatly simplify the workflow committers go through with pull requests from the community. It will also allow us to close out pulls that go dark. On our local repos we would really have no need to ever include the apache repo so it reduces the number of remotes we need

Gitbox enables the full GitHub workflow

Hi! it has just come to my attention that Gitbox at ASF has been enabling full GitHub workflow (with being able to click Merge this PR button, etc.) for quite some time. This basically allows a project to have GH as a R/W repo as opposed to R/O mirror of what we all currnently have:

Re: Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61487/#review182347 ---

Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61487/ --- Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and

[GitHub] geode pull request #697: GEODE-3407: fix deadlock between JMX and Reconnect

GitHub user kirklund opened a pull request: https://github.com/apache/geode/pull/697 GEODE-3407: fix deadlock between JMX and Reconnect Change InternalClientMembership to not synchronize on CacheFactory by accepting Cache parameter from CacheServerBridge. New regression

[GitHub] geode pull request #690: GEODE-3262: Refactoring IndexCommands

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/690#discussion_r131790263 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateIndexCommand.java --- @@ -0,0 +1,197 @@ +/* + *

[GitHub] geode issue #691: GEODE-3260: Refactoring FunctionCommands

Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/691 +1. A far-from-critical nitpick: there are several places in `ExecuteFunctionCommand` and one in `DestroyFunctionCommand` that are of the form ``` result =

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131787338 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ValidateDiskStoreCommand.java --- @@ -0,0 +1,107 @@ +/* + *

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131787137 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ValidateDiskStoreCommand.java --- @@ -0,0 +1,107 @@ +/* + *

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131787085 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/UpgradeOfflineDiskStoreCommand.java --- @@ -0,0 +1,179 @@ +/*

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131775864 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java --- @@ -333,9 +247,8 @@ private void

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131776451 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java --- @@ -359,7 +272,7 @@ private

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131783322 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListRegionCommand.java --- @@ -0,0 +1,113 @@ +/* + *

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/693#discussion_r131775100 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/RegionCommandsController.java --- @@ -26,11 +26,12 @@

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131783193 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactOfflineDiskStoreCommand.java --- @@ -0,0 +1,178 @@ +/*

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131783008 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactDiskStoreCommand.java --- @@ -0,0 +1,185 @@ +/* + *

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131782938 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactOfflineDiskStoreCommand.java --- @@ -0,0 +1,178 @@ +/*

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #640 was SUCCESSFUL (with 2024 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #640 was successful. --- Scheduled 2026 tests in total. https://build.spring.io/browse/SGF-NAG-640/ -- This

[GitHub] geode pull request #696: GEODE-3265: Refactoring MiscellaneousCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/696 GEODE-3265: Refactoring MiscellaneousCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3265) `MiscellaneousCommands` was a huge class that contained a large

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/687#discussion_r131777554 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactDiskStoreCommand.java --- @@ -0,0 +1,185 @@ +/* + *

[GitHub] geode pull request #695: GEODE-3267: Refactoring QueueCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/695 GEODE-3267: Refactoring QueueCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3267) `QueueCommands` was a big class that contained two commands (each class

[GitHub] geode pull request #694: GEODE-3270: Refactoring (renaming) StatusCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/694 GEODE-3270: Refactoring (renaming) StatusCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3270) `StatusCommands` was a class that already contained a

[DRAFT] Geode Board Report August 2017

Hi folks, Please review the below draft for our report to the board for this past quarter and offer corrections. As Mark mentioned, we need to submit the draft this Wednesday. Thanks! -Dan - ## Description: - Apache Geode provides a

[GitHub] geode pull request #693: GEODE-3268: Refactoring RegionCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/693 GEODE-3268: Refactoring RegionCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3268) `RegionCommands` was a big class that contained too many commands

[GitHub] geode-native pull request #114: GEODE-2729: Remove global variables

GitHub user dgkimura opened a pull request: https://github.com/apache/geode-native/pull/114 GEODE-2729: Remove global variables - Remove CacheImpl::getInstance calls - Converted PdxTypeRegistry clear to non-static method - Adding Type Registry to cpp code as a public object.

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

> On Aug. 7, 2017, 8:21 p.m., Jared Stewart wrote: > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java > > Lines 140 (patched) > > > > > > Can you clarify something for

Re: Review Request 61472: GEODE-3097: fix an accidental bug introduced when working on ssl over http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61472/#review182315 --- Ship it! Ship It! - Jared Stewart On Aug. 7, 2017, 5:18

[GitHub] geode pull request #692: GEODE-3264: Refactoring MemberCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/692 GEODE-3264: Refactoring MemberCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3264) `MemberCommands` was a big class that contained too many commands

Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

[GitHub] geode pull request #691: GEODE-3260: Refactoring FunctionCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/691 GEODE-3260: Refactoring FunctionCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3260) `FunctionCommands` was a huge class that contained a large number of

[GitHub] geode pull request #690: GEODE-3262: Refactoring IndexCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/690 GEODE-3262: Refactoring IndexCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3262) `IndexCommands` was a huge class that contained a large number of

Re: continuous query internal mechanism

CQ Processing on server side is same for all clients (Java, C++)... The subscription events are sent to client as ClientUpdateMessage, which holds information about registered events and CQ events. The client process this and updates/invokes the client side cache/listeners with respective event.

[GitHub] geode pull request #689: GEODE-3259: Refactoring DurableClientCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/689 GEODE-3259: Refactoring DurableClientCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3259) `DurableClientCommands` was a huge class that contained a large

[GitHub] geode issue #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on the issue: https://github.com/apache/geode/pull/687 I'll go ahead and review your command refactorings in this PR, keeping in mind that the test will be dealt with under the other JIRA. I agree with not changing those two DUnit tests at this time.

RE: continuous query internal mechanism

Thanks, By the way, is there any difference in the behaviour of the server, if the client that registered the CQ is a native (C++) client? I have been going over the classes and code for some time and can't seem to find the actual location where a CQ update/notification is sent... It's like

Build failed in Jenkins: Geode-nightly #916

See Changes: [hkhamesra] GEODE-3286: Failing to cleanup connections from ConnectionTable [hkhamesra] GEODE-3307: CI failure: Uncaught exception in Membership View Creator [ukohlmeyer] GEODE-3321: Adding ErrorCode

Request to blacklist H2 on Apache Nightly Builds

Hi We need to blacklist H2 machine from running the Apache Nightly builds for Apache Geode project. Please can someone with the necessary permission do it. Regards Nabarun Nag

[GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/591 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: continuous query internal mechanism

You can find those in CqServiceImpl.process*()... -Anil. On Mon, Aug 7, 2017 at 9:14 AM, Roi Apelker wrote: > Hello, > > I am trying to look into the code of the continuous query mechanism - > where the GEODE server sends the notification back to the client. > > Can

Review Request 61472: GEODE-3097: fix an accidental bug introduced when working on ssl over http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61472/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

[GitHub] geode issue #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily commented on the issue: https://github.com/apache/geode/pull/687 @pdxrunner The tests that cover these commands are part of a separate JIRA ticket ([GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359)), so @jinmeiliao recommended just refactoring the

[GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/685#discussion_r131705221 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java --- @@ -34,7 +36,7 @@ public static void

Re: Need to know complete execution time for geode-core Junit tests

For test004StartServerFailsFastOnMissingGemFirePropertiesFile I think this test just needs to be improved for Windows. The test has an assertion that the failure message contains a certain string. On Windows the message contains "C:" and "\" which the test does not expect. Instead of the test

continuous query internal mechanism

Hello, I am trying to look into the code of the continuous query mechanism - where the GEODE server sends the notification back to the client. Can anyone point me to the central classes of continuous query, especially to the one that is responsible for the calculation of the new data and

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

Hi Jinmei, 1. Yes, a parallel change would be good for keystore. In both cases, we need to specify the default. My sample text said empty string ('') -- is that correct, or is the default JKS? 2 & 3: Good - glad they're correct. I wasn't sure, just noticed the patterns. -Dave On Sat, Aug 5, 2017

Re: Volunteer Request: Write Draft Board Report For August 2017

Hi Mark, I can take this on. I'll try to get a draft out today. -Dan On Fri, Aug 4, 2017 at 12:06 PM, Mark Bretl wrote: > Hi Everyone, > > We are scheduled to report to the Apache board for this months board > meeting on August 16 and need to submit a report by Wednesday,

RE: Need to know complete execution time for geode-core Junit tests

Hi Team, When we run : ./gradlew integrationTest ./gradlew distributedTest Many test are getting failed with head allocation error or configuration error. Can you please suggest , what extra configuration we need to do . I am able to run Junit correctly. unit tests - run with ./gradlew test

RE: Need to know complete execution time for geode-core Junit tests

Hi Team, When we are running test on windows : we are getting below error We ran : gradlew precheckin rg.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest > test003StartServerFailsFastOnMissingCacheXmlFile FAILED java.lang.AssertionError: Warning: The