Re: [PROPOSAL] Public API for Cluster Configuration

2018-03-13 Thread Jinmei Liao
John, great points. I updated the wiki page with some bullet points that might address your concerns. Goals - The API is intended to ONLY update the cluster or server-group's configuration saved by the locator(s). For example, when developer uses the api to add a region definition to

Broken Integration Tests due to putIfAbsent

2018-03-13 Thread Galen O'Sullivan
Hi all, I committed some code recently that looks like it broke the CI. However, based on the failure, I think it will still fail if I revert the commit. I'm currently testing a small hotfix and will apply it if it passes tests. Sorry for the inconvenience. Thanks, Galen GEODE-4836

Geode unit tests completed in 'develop/FlakyTest' with non-zero exit code

2018-03-13 Thread apachegeodeci
Pipeline results can be found at: Concourse: https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/FlakyTest/builds/308

Geode unit tests completed in 'develop/IntegrationTest' with non-zero exit code

2018-03-13 Thread apachegeodeci
Pipeline results can be found at: Concourse: https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/IntegrationTest/builds/275

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #855 was SUCCESSFUL (with 2379 tests)

2018-03-13 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #855 was successful. --- Scheduled 2381 tests in total. https://build.spring.io/browse/SGF-NAG-855/ -- This

Re: [PROPOSAL] Public API for Cluster Configuration

2018-03-13 Thread John Blum
Some initial thoughts after looking over the spec... 1. As a developer (application, API/framework, tool or even a module developer), I really don't care nor should I care what Apache Geode is storing the configuration as under-the-hood. It could be XML, JSON, YAML, a database or even some

Geode unit tests completed in 'develop/IntegrationTest' with non-zero exit code

2018-03-13 Thread apachegeodeci
Pipeline results can be found at: Concourse: https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/IntegrationTest/builds/274

Re: Need permissions to Geode JIRA

2018-03-13 Thread Dan Smith
Hi Blake, What's I added you, you should have permission now. -Dan On Tue, Mar 13, 2018 at 1:12 PM, Blake Bender wrote: > Hello, > > I need to be able to update tickets in Geode JIRA, can someone please set > me up with appropriate permissions? > > Thanks, > > Blake >

Need permissions to Geode JIRA

2018-03-13 Thread Blake Bender
Hello, I need to be able to update tickets in Geode JIRA, can someone please set me up with appropriate permissions? Thanks, Blake

Re: [PROPOSAL] Public API for Cluster Configuration

2018-03-13 Thread Jinmei Liao
for normal usages, developers will only need to use the updateCacheConfig(groupName, mutator) api, like: service.updateCacheConfig("cluster", cacheConfig->{ cacheConfig.getRegion().add(aRegionConfig); cacheConfig.getAsyncEventQueue().add(aQueue); return cacheConfig; }); Only when module

Re: [PROPOSAL] Public API for Cluster Configuration

2018-03-13 Thread Patrick Rhomberg
Hmm... Jinmei has it right -- that the *Element were for declaring custom XML entries -- but they were only really used during exploration. With this minimal API, we're not actually using those interface-tags in a publicly-visible way... Now I'm torn. On the one hand, it seems a bit strange to

Re: FunctionService Proposal

2018-03-13 Thread John Blum
+1 Udo. A very clear and descriptive spec; Nice work! In short, these would be welcomed changes and would have very little impact to *Spring Data for Apache Geode*, which nicely abstracts this API even further using its POJO-based, Annotation configuration model for Function Implementations as

Re: [PROPOSAL] Public API for Cluster Configuration

2018-03-13 Thread Jinmei Liao
1. CacheElement/RegionElement are used for custom xml element that are to be added by other modules. They are not meant for those elements defined by cache.xsd already, like region, gatewayreceiver etc. Maybe we should rename it back CustomCacheElement/CustomRegionElement 1. the mutator updates

Re: [PROPOSAL] Public API for Cluster Configuration

2018-03-13 Thread Sai Boorlagadda
I have few comments: 1, What is ClusterElement/RegionElement interfaces used for? 2. I see that using unary mutator one can mutate both cache and region configurations, so the methods in ClusterConfigurationService can be getClusterConfig and updateClusterConfig? The naming is debatable as

Re: [PROPOSAL] Public API for Cluster Configuration

2018-03-13 Thread Patrick Rhomberg
All, I have added a section "Additional Concerns" addressing security and concurrent use of the proposed interface. Imagination is Change. ~Patrick

[PROPOSAL] use default value for validate-serializable-objects in dunit

2018-03-13 Thread Kirk Lund
I want to propose using the default value for validate-serializable-object in dunit tests instead of forcing it on for all dunit tests. I'm sympathetic to the reason why this was done: ensure that all existing code and future code will function properly with this feature enabled. Unfortunately