[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1012 has FAILED (14 tests failed)

2018-08-17 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1012 failed. --- Scheduled 14/2425 tests failed. https://build.spring.io/browse/SGF-NAG-1012/ -

Re: [Proposal] SSL - hostname verification

2018-08-17 Thread Jacob Barrett
Are we implementing the identification algorithm ourself or using one provided by setting that algorithm property? If we are implementing our own or just setting the algorithm to HTTPS and don’t foresee us using the LDAPS then a Boolean is sufficient. There isn’t really a whole lot different bet

Re: [Proposal] SSL - hostname verification

2018-08-17 Thread Sai Boorlagadda
Thanks, Jake for the feedback. The reason for endpoint-identification in the parameter name is to be aligned with JDK. So maybe making it as 'ssl-endpoint-identification-enabled' would have been less confusing. I also want to bring to notice that in JDK its a string property in SSLParameters.setEn

Re: [Proposal] SSL - hostname verification

2018-08-17 Thread Jacob Barrett
My biggest concern now is the name of the property to enable this. 'ssl-enabled-endpoint-identification' in no way suggests any kind of validation. The word identification implies to me that it will identify and maybe log endpoints. I would change that to validation or some other term that impl