[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1044 was SUCCESSFUL (with 2456 tests)

2018-09-18 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1044 was successful. --- Scheduled 2458 tests in total. https://build.spring.io/browse/SGF-NAG-1044/ -- Thi

Re: [VOTE] Apache Geode 1.7.0 RC1

2018-09-18 Thread Dan Smith
+0 I noticed that someone added some files called "out" to the repo that aren't included in the source distribution: ./ci/resource-types/gce-instances-resource/out ./ci/resource-types/concourse-metadata-resource/files/out These aren't included in the source distribution because we are explicitly

Re: [VOTE] Apache Geode 1.7.0 RC1

2018-09-18 Thread Dave Barnes
+1 Downloaded, ran some gfsh commands, opened & browsed javadocs. On Tue, Sep 18, 2018 at 2:16 PM, Jinmei Liao wrote: > +1 downloaded the distribution, ran gfsh and execute random gfsh commands > and verified pulse. > > On Tue, Sep 18, 2018 at 1:36 PM Ryan McMahon wrote: > > > +1 > > > > - Read

Re: [VOTE] Apache Geode 1.7.0 RC1

2018-09-18 Thread Jinmei Liao
+1 downloaded the distribution, ran gfsh and execute random gfsh commands and verified pulse. On Tue, Sep 18, 2018 at 1:36 PM Ryan McMahon wrote: > +1 > > - Read release notes and verified no incorrect/misspelled content > - Verified clean build from source > - Built and ran all geode-examples >

Re: [VOTE] Apache Geode 1.7.0 RC1

2018-09-18 Thread Ryan McMahon
+1 - Read release notes and verified no incorrect/misspelled content - Verified clean build from source - Built and ran all geode-examples Ryan On Mon, Sep 17, 2018 at 5:33 PM, Anthony Baker wrote: > +1 > > Reviewed LICENSE and NOTICE* > Verified signatures and hashes > Checked source releas

Re: Need gradle help

2018-09-18 Thread Kirk Lund
It's working now, thanks! I also added test-sources so it's easier to link the source code for studying their code while working on it: + integrationTestCompile 'org.apache.logging.log4j:log4j-core:' + project.'log4j.version' + ':tests' + integrationTestCompile 'org.apache.logging.log4j:log4j-c

Re: Steps to follow after becoming a Geode committer

2018-09-18 Thread Kirk Lund
I reviewed your changes and added approval. Thanks Juan! On Tue, Sep 18, 2018 at 12:46 AM, Juan José Ramos wrote: > Hello Jinmei and Dan, > > Thanks both for the reply!!. > Regarding pull 2250, I think the changes requested by Galen are outdated > now, but I'll ping him directly in the *pull req

Re: Steps to follow after becoming a Geode committer

2018-09-18 Thread Juan José Ramos
Hello Jinmei and Dan, Thanks both for the reply!!. Regarding pull 2250, I think the changes requested by Galen are outdated now, but I'll ping him directly in the *pull request * anyway to be sure. Best regards. On Mon, Sep 17, 2018 at 5:37 PM Dan Smith wrote: > Hi Juan, > > Great questions! I