Re: LoggingTest category

2018-09-27 Thread Patrick Rhomberg
Tangentially related, we have a test-by-category.gradle. Is anyone using any of those targets? I suspect that many of these targets are no longer stable or correctly configured ever since we restructured tests around integrationTest / distributedTest / etc. Running `./gradlew securityTest` local

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1053 was SUCCESSFUL (with 2456 tests)

2018-09-27 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1053 was successful. --- Scheduled 2458 tests in total. https://build.spring.io/browse/SGF-NAG-1053/ -- Thi

[Discuss] Transitive dependencies and internal .pom changes

2018-09-27 Thread Patrick Rhomberg
Hello all! # As a one paragraph elevator pitch: A module should declare its own dependencies and not expose those dependencies to a consumer unless explicitly intending to do so. As part of working towards better decoupling between Geode's modules, we should eliminate our reliance on transitiv

GfshParserRule failures are very cryptic

2018-09-27 Thread Kirk Lund
Does anyone know GfshParserRule well enough that we could make the test failures provide some useful info? If you could give me some pointers on where/what to improve I'm happy to do the footwork. Or if you prefer to do that's fine as well. For example, I have a PR with GfshParserAutoCompletionTe

Rat is failing due to generated files under bin directories

2018-09-27 Thread Kirk Lund
Command-line build seems to create these bin directories under each module which is fine. But now Rat is failing because of the generated files under these bin directories. This in turn causes my local command-line build to fail. Does anyone know how to make this problem go away without using "-x

Re: GfshParserRule failures are very cryptic

2018-09-27 Thread Kirk Lund
I found the answer... Change lines in the test from this: assertThat(candidate.size()).isEqualTo(8); To this: assertThat(candidate.getCandidates()).hasSize(8); And now I get this failure which is much more helpful: Sep 27, 2018 4:36:50 PM org.springframework.shell.core.SimpleParser di

[VOTE] Apache Geode 1.7.0 RC2

2018-09-27 Thread Nabarun Nag
This is the second release candidate for Apache Geode, version 1.7.0. Thanks to all the community members for their contributions to this release! Please do a review and give your feedback. The deadline is the end of day 2nd October 2018. It resolves 351 issues on Apache Geode JIRA system. Releas

Re: Rat is failing due to generated files under bin directories

2018-09-27 Thread Anthony Baker
That’s weird—I would expect any generated files to go into build/. Anyone know why stuff is landing in bin? Anthony > On Sep 27, 2018, at 7:25 PM, Kirk Lund wrote: > > Command-line build seems to create these bin directories under each module > which is fine. > > But now Rat is failing beca

Re: Rat is failing due to generated files under bin directories

2018-09-27 Thread Sai Boorlagadda
Intellij .uses 'bin' as output folder. On Thu, Sep 27, 2018 at 6:56 PM Anthony Baker wrote: > That’s weird—I would expect any generated files to go into build/. Anyone > know why stuff is landing in bin? > > Anthony > > > > On Sep 27, 2018, at 7:25 PM, Kirk Lund wrote: > > > > Command-line bui

Re: [Discuss] Transitive dependencies and internal .pom changes

2018-09-27 Thread Anthony Baker
I don’t follow why we should get rid of transitive dependencies. Can you help me understand? How does this help with decoupling modules? The whole java ecosystem is based on declaring and consuming transitive dependencies via maven pom’s. I get the api/implementation dependency separation,

Re: [VOTE] Apache Geode 1.7.0 RC2

2018-09-27 Thread Nabarun Nag
Following checks completed: - checked signatures -src.tgz -examples.tgz -.tgz - checked SHA's -src.tgz -examples.tgz -.tgz - builds from source - run gfsh - start locator, server - create region - do put and get - execute OQL query - examples run cleanly - the correct version in gfsh command versio

Re: Rat is failing due to generated files under bin directories

2018-09-27 Thread Sai Boorlagadda
Kirk, We can exclude bin directory in `gradle/rat.gradle`. Sai On Thu, Sep 27, 2018 at 7:02 PM Sai Boorlagadda wrote: > Intellij .uses 'bin' as output folder. > > On Thu, Sep 27, 2018 at 6:56 PM Anthony Baker wrote: > >> That’s weird—I would expect any generated files to go into build/. >> An