Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-10-31 Thread Bill Burcham
+1 for exposing getCache() on CacheLauncher instances. Death to all singletons! I'm less certain about the wisdom of exposing a getCache() on LocatorLauncher instances. Seems like it would be better to let clients call getLocator() on LocatorLauncher instances, then they can do the traversal to th

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1087 was SUCCESSFUL (with 2457 tests)

2018-10-31 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1087 was successful. --- Scheduled 2459 tests in total. https://build.spring.io/browse/SGF-NAG-1087/ -- Thi

Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-10-31 Thread Dan Smith
Yay for APIs that don't require singletons! -Dan On Wed, Oct 31, 2018 at 2:54 PM Jinmei Liao wrote: > +1. sounds like a good addition and since we already have package level > getters for them anyway. > > On Wed, Oct 31, 2018 at 2:48 PM Kirk Lund wrote: > > > LocatorLauncher provides an API wh

Re: [PROPOSAL] Add getCache and getLocator to Launchers

2018-10-31 Thread Jinmei Liao
+1. sounds like a good addition and since we already have package level getters for them anyway. On Wed, Oct 31, 2018 at 2:48 PM Kirk Lund wrote: > LocatorLauncher provides an API which can be used in-process to create a > Locator. There is no public API on that class to get a reference to the >

[PROPOSAL] Add getCache and getLocator to Launchers

2018-10-31 Thread Kirk Lund
LocatorLauncher provides an API which can be used in-process to create a Locator. There is no public API on that class to get a reference to the Locator or its Cache. Similarly, ServerLauncher provides an API which can be used in-process to create a Server, but there is no public API in that class

Re: Pull request precheckin not firing automatically

2018-10-31 Thread Kirk Lund
Just in case, others hit this: The one I was asking about failed with "missing inputs: geode, instance-data" which Dan said means that Concourse barfed. When this happens, pushing an empty commit or anything else was recommended to re-trigger. https://concourse.apachegeode-ci.info/teams/main/pipel

Re: Pull request precheckin not firing automatically

2018-10-31 Thread Patrick Rhomberg
Just to disseminate the knowledge... Although we like it when everyone just works nicely, you can check the consumption of your PR in the Concourse by looking at the *geode* resource in the *apache-develop-pr* pipeline [1]. This resource passes the PR number and associated SHA to test against, so

Geode 1.8 Release Manager

2018-10-31 Thread Dan Smith
We are coming up on the date where we said we would start the 1.8 release (Nov 1st). Any volunteers to be release manager for this release? -Dan