Okay. Please go ahead and merge, I can’t since I’m not a committer.
On Thu, Dec 20, 2018 at 3:00 PM Kirk Lund wrote:
> Looks good. Thanks! I added my approval.
>
> On Thu, Dec 20, 2018 at 2:20 PM Aditya Anchuri
> wrote:
>
> > PR to fix: https://github.com/apache/geode/pull/3030
> >
> > On Thu,
Thank you for catching this Brian! I will take a look and see how we can
address this.
On Thu, Dec 20, 2018 at 3:21 PM Brian Rowe wrote:
> The maven repository for 1.8.0 seems to be missing the 1.8.0 source jars.
> This means people using an IDE can't download these jars automatically to
> see
The maven repository for 1.8.0 seems to be missing the 1.8.0 source jars.
This means people using an IDE can't download these jars automatically to
see the geode source in their IDE.
Specifically, we see the following in 1.8 vs 1.7:
Looks good. Thanks! I added my approval.
On Thu, Dec 20, 2018 at 2:20 PM Aditya Anchuri wrote:
> PR to fix: https://github.com/apache/geode/pull/3030
>
> On Thu, Dec 20, 2018 at 1:58 PM Aditya Anchuri
> wrote:
>
> > These classes were removed recently, but it looks like we forgot to clean
> >
I have enough trouble just getting other developers to review my PR. I
don't want to have to struggle to find someone to merge it for me, too.
On Mon, Nov 19, 2018 at 4:09 PM Udo Kohlmeyer wrote:
> I don't believe "name and shame" is a hammer we should wield, but if we
> have use it... use it
PR to fix: https://github.com/apache/geode/pull/3030
On Thu, Dec 20, 2018 at 1:58 PM Aditya Anchuri wrote:
> These classes were removed recently, but it looks like we forgot to clean
> up the javadocs. Will make a PR to fix ASAP.
>
> -Aditya
>
> On Thu, Dec 20, 2018 at 1:57 PM Kirk Lund wrote:
+1 to blocking the "merge" button
On Mon, Nov 19, 2018 at 5:09 PM Udo Kohlmeyer wrote:
> I don't believe "name and shame" is a hammer we should wield, but if we
> have use it... use it wisely
>
> Could one not configure the button that the owner of the PR cannot merge
> the PR?
>
> --Udo
>
>
>
These classes were removed recently, but it looks like we forgot to clean
up the javadocs. Will make a PR to fix ASAP.
-Aditya
On Thu, Dec 20, 2018 at 1:57 PM Kirk Lund wrote:
> Just a reminder that any classes not behind internal packages need to have
> functional Javadocs.
>
> We have
Just a reminder that any classes not behind internal packages need to have
functional Javadocs.
We have Javadoc errors involving
org/apache/geode/cache/configuration/RegionAttributesType.java referring to
RegionTimeToLive which I can't find when I grep.
> Task :geode-assembly:docs
