Since this [DISCUSS] topic did not attract any opinion, this change was
incorporated into “make windows gating” PR
https://github.com/apache/geode/pull/3597 since otherwise substantial extra
changes would have been needed to avoid creating a circular dependency.
The super-tall main pipeline vie
I’ve created a PR for this: https://github.com/apache/geode/pull/3597
> On May 16, 2019, at 3:06 PM, Blake Bender wrote:
>
> +1 this needs to happen. I hope that doesn't cause too much pain for the
> dev team, but the native client team has a hard requirement that all our
> stuff works properly
I’ve created a PR for this, please give it a +1:
https://github.com/apache/geode/pull/3598
> On May 16, 2019, at 11:12 AM, Anilkumar Gingade wrote:
>
> Make sense to me...Looking at the probability of breaking specific to, jdk8
> and jdk11 through a commit.
>
>
> On Wed, May 15, 2019 at 6:09
+1 this needs to happen. I hope that doesn't cause too much pain for the
dev team, but the native client team has a hard requirement that all our
stuff works properly on Windows at all times, and it can cause trouble if
random builds of the server can break us on Windows.
I would hesitate to run
big +1, as long as artifacts of failed runs can be downloaded
On 5/15/19 6:28 PM, Owen Nichols wrote:
For a very long time we’ve had Windows tests in the main pipeline (hidden away,
not in the default view), but the pipeline proceeds to publish regardless of
whether Windows tests fail or even
Agreed on making them gating if we want to say we run on Windows. If we
don't want to say we run on Windows, delete the jobs.
-michael
On Thursday, May 16, 2019, Anilkumar Gingade wrote:
> >> around 5 hours, vs 2 hours for Linux tests).
> May be a good time to look at reducing/optimizing this.
Make sense to me...Looking at the probability of breaking specific to, jdk8
and jdk11 through a commit.
On Wed, May 15, 2019 at 6:09 PM Owen Nichols wrote:
> Currently every PR commit triggers both JDK8 and JDK11 versions of each
> test job. I propose that we can eliminate the JDK8 version of
>> around 5 hours, vs 2 hours for Linux tests).
May be a good time to look at reducing/optimizing this.
On Thu, May 16, 2019 at 9:57 AM Ernest Burghardt
wrote:
> Yes make them gating.
> Run them every commit, Windows is a supported platform.
> Red boxes get attention and Red boxes get fixed.
>
Yes make them gating.
Run them every commit, Windows is a supported platform.
Red boxes get attention and Red boxes get fixed.
EB
On Thu, May 16, 2019 at 1:09 AM Udo Kohlmeyer wrote:
> I think we need to make sure our windows tests get to green... If we
> make them gating then we will never rel
I think we need to make sure our windows tests get to green... If we
make them gating then we will never release, but at the time be
motivated to fix them, in order to release.
Maybe they run once every day... to at least start getting an idea of health
On 5/15/19 18:28, Owen Nichols wrote:
F
10 matches
Mail list logo
