Re: Permission for wiki

2019-05-28 Thread Dan Smith
Added - you should have access now! Thanks, -Dan On Tue, May 28, 2019 at 3:28 PM Jack Weissburg wrote: > Hello, > > I would like to have permission to edit the wiki: > > https://cwiki.apache.org/confluence/display/GEODE/Guidelines+for+Cluster+Management+service > > Thank you, > > Jack

Re: [DISCUSS] Remove exception.getMessage() error handling

2019-05-28 Thread Nabarun Nag
Looking at the ticket, it looks like it is an improvement request for some additional information for the end user, can we just do what Kirk and Bruce suggested. Add some logs to explain what happened. In my opinion, an end user will be more happy to get some detail information rather than an

Permission for wiki

2019-05-28 Thread Jack Weissburg
Hello, I would like to have permission to edit the wiki: https://cwiki.apache.org/confluence/display/GEODE/Guidelines+for+Cluster+Management+service Thank you, Jack Weissburg

Re: [DISCUSS] Remove exception.getMessage() error handling

2019-05-28 Thread Owen Nichols
This example came from https://issues.apache.org/jira/browse/GEODE-6796 in which the submitter assumed that Geode was deliberately emitting a poorly-worded and confusing error message. @abaker It sounds like your recommendation for this particular ticket would be to resolve as ’Not A Bug’, is

Re: [DISCUSS] Remove exception.getMessage() error handling

2019-05-28 Thread Kirk Lund
I favor providing a detailed log message that includes the Throwable as an argument. I have seen code like the following in Geode: } catch (Exception exception) { logger.error(exception.getMessage()); } ...but I consider that to be a naive anti-pattern for informing the user that a problem

Re: [DISCUSS] Remove exception.getMessage() error handling

2019-05-28 Thread Bruce Schuchardt
In some ways I agree with Owen - it's always better to have more information about a problem.  I can recall seeing blank error messages or "null" on many occasions. In other ways I agree with Dan and Anthony that this needs to not be a global search, but I think that's mostly because our

Re: [DISCUSS] Remove exception.getMessage() error handling

2019-05-28 Thread Anthony Baker
In the example you provided, I don’t agree that adding the exception class name creates a better user experience. Anthony > On May 25, 2019, at 6:39 PM, Owen Nichols wrote: > > Here’s an example of a message that was logged before Jack’s change: > > l192.168.99.1: nodename nor servname