Re: [DISCUSS] Adoption of a Coding Standard

2019-06-27 Thread Ernest Burghardt
Here's some food for thought on creating coding standards... 1. You can't please everyone all of the time or in all aspects and this becomes "Hero" driven or a "holy war" 2. Creating a custom standard is very time/resource consuming and (see #1) 3. Adopting an objectively maintained industry

Re: [DISCUSS] Adoption of a Coding Standard

2019-06-27 Thread Aaron Lindsey
+1 to having a recommended reading list. At first glance, the SEI standard seems like an extremely useful resource, but I am hesitant to adopt it as our "coding standard" without carefully reading all the way through it. I would, however, be comfortable adding it to a recommended reading list. -

GEODE-6637

2019-06-27 Thread Murtuza Boxwala
Problem: Every time we make a put the code in BucketRegion.searchAndLock and BucketRegion.removeAndNotifyKeys locks (synchronized) on a hash map, the allKeysMap, to checkout the key to be modified and prevent anyone else from updating at the same time. This area of the code gets a lot of