Re: [DISCUSS] enable GitHub PR blocking on API breaking changes

2020-05-14 Thread Mark Hanson
+1. The more we can automate this types of checks the better. Thanks, Mark

Re: [DISCUSS] enable GitHub PR blocking on API breaking changes

2020-05-14 Thread Nabarun Nag
+1 On Thu, May 14, 2020 at 8:54 AM Donal Evans wrote: > Thanks for the explanation, Robert. Also, I realised I never explicitly > said it in my earlier post, but this is a +1 from me > > On Thu, May 14, 2020 at 8:05 AM Joris Melchior > wrote: > > > This seems like a good thing to have. > > > >

Re: [DISCUSS] enable GitHub PR blocking on API breaking changes

2020-05-14 Thread Donal Evans
Thanks for the explanation, Robert. Also, I realised I never explicitly said it in my earlier post, but this is a +1 from me On Thu, May 14, 2020 at 8:05 AM Joris Melchior wrote: > This seems like a good thing to have. > > +1 > > From: Robert Houghton > Sent: Ma

Re: [DISCUSS] enable GitHub PR blocking on API breaking changes

2020-05-14 Thread Joris Melchior
This seems like a good thing to have. +1 From: Robert Houghton Sent: May 13, 2020 17:32 To: dev@geode.apache.org ; Mario Ivanac Subject: [DISCUSS] enable GitHub PR blocking on API breaking changes We have enabled this job on the develop and support 1.13 branche

Re: Update of SSLParameterExtension interface

2020-05-14 Thread Robert Houghton
There is an opportunity to take @Jacob Barrett s advice on using a real configuration class instead of an opaque 'Properties' class here. See https://github.com/apache/geode/pull/5115, where we test the API breaking change with an exemption file. On Thu, May 7, 2020 at 8:52 AM Jacob Barrett wrote

Re: [DISCUSS] enable GitHub PR blocking on API breaking changes

2020-05-14 Thread Robert Houghton
@donal There is a violation filter in place for major version changes that would currently allow any change. That can be narrowed down to only allow deletion of already-deprecated signatures. On Wed, May 13, 2020 at 5:18 PM Owen Nichols wrote: > If ApiChecker fails on your PR, and you merge anyw

Re: About Geode rolling downgrade

2020-05-14 Thread Alberto Gomez
Hi, I friendly reminder to the community about this request for feedback. Thanks, -Alberto G. From: Alberto Gomez Sent: Thursday, May 7, 2020 10:44 AM To: geode Subject: Re: About Geode rolling downgrade Hi again, Considering Geode does not support online ro