Examples of good Mocking in tests

2021-02-19 Thread Kirk Lund
There are quite a few examples of good mocking in both unit tests and integration tests, with the majority being in unit tests. An easy way to find many of these tests in Geode is to grep for uses of MockitoRule with STRICT_STUBS. Also, remember that if the test touches disk or network then it's a

Re: code-owners seems to have some problems

2021-02-19 Thread Bruce Schuchardt
Thanks Owen. Good to know about the keyhole/shield icons. The filter function doesn't work as well as I hoped. The shield icons that matched my username in CODEOWNERS are BOLD while the others are a bit greyed out; Using that I was able to identify a few files that matched line 28 in CODEOWN

Re: code-owners seems to have some problems

2021-02-19 Thread Owen Nichols
GitHub provides some tools to answer this kind of question. Step 1: Under the PR's "Files Changed" tab, click File Filter > Your CODEOWNER files Step 2: Hover over the keyhole/shield icon (to the left of the red/green changecount graphic to the left of each filename) to see who else is also owne

code-owners seems to have some problems

2021-02-19 Thread Bruce Schuchardt
I was pulled in to PR 5989 but can’t figure out how that happened with the current CODEOWNERS file. These all seem out of my area: boms/geode-all-bom/src/test/resources/expected-pom.xml buildSrc/src/main/groovy/org/apache/geode/gradle/plugins/Depend

Re: Adding 1.14 blocker label for GEODE-8671

2021-02-19 Thread Owen Nichols
+1 Thanks for looking into this! It sounds like a serious issue and tracking this as a blocker will ensure we don't ship before you've had a chance to get to the bottom of it. Please provide status update to the ticket about once a week if the progress is taking long. On 2/19/21, 11:12 AM,

Adding 1.14 blocker label for GEODE-8671

2021-02-19 Thread Anilkumar Gingade
We are investigating GEODE-8671; while investigation is in progress we like to treat this as a 1.14 blocker. https://issues.apache.org/jira/browse/GEODE-8671 Thanks, -Anil.