> On Apr 15, 2021, at 7:49 PM, Udo Kohlmeyer wrote:
>
> @jake, you are correct, I did miss the LOCAL variable out of the subject.
> :face_palm:
>
> Yes, adding "final" to LOCAL variables will be HUGELY beneficial in this
> regard. Have we seen any performance improvement after having refact
@jake, you are correct, I did miss the LOCAL variable out of the subject.
:face_palm:
Yes, adding "final" to LOCAL variables will be HUGELY beneficial in this
regard. Have we seen any performance improvement after having refactored this
method? Have you been able to measure any improvements?
-
PS: Here is my version of that constructor after refactoring the class:
PartitionedRegionClearMessage(Set recipients,
PartitionedRegion region,
ReplyProcessor21 processor, PartitionedRegionClearMessage.OperationType
operationType,
RegionEventImpl event) {
super(recipients, region.getPRId
Here's a quote about code reviews in Clean Code in Python:
We should invest time in code reviews, thinking about what is good code,
> and how readable and understandable it is. When looking at the code written
> by a peer, you should ask such questions as:
> * Is this code easy to understand and f
Moving the discussion to this thread. Sorry for starting off with a VOTE.
I'm primarily interested in Maintainability
https://en.wikipedia.org/wiki/Software_quality#Maintainability, and my
concern regarding using "final" on method parameters or local variables is
about Code Readability: understand
Sorry Bruce, that's my lack of Apache finesse. I know you might expect me
to remember it but I don't start discussions or votes often enough to
remember. I'll be sure to read up on this process before starting any
threads in the future.
On Thu, Apr 15, 2021 at 7:32 AM Bruce Schuchardt wrote:
> I
I agree with Udo. Also, this shouldn't be a VOTE without discussion and I
don't see a DISCUSS thread.
On 4/14/21, 7:46 PM, "Udo Kohlmeyer" wrote:
"+1" to ENCOURAGING developers to make "final" a requirement for method
arguments.
"-1" to making it a hard rule.
If we want to enfor
