Re: Added Support for JUnit 5

2021-10-12 Thread Jacob Barrett
This is amazing! > On Oct 12, 2021, at 3:37 PM, Dale Emery wrote: > > In September 2021, Geode added support for writing and running tests using > JUnit 5. > > Most Geode modules now support JUnit 5. For most Geode modules, you can now > write each test class using either JUnit 5's "Jupiter"

Added Support for JUnit 5

2021-10-12 Thread Dale Emery
In September 2021, Geode added support for writing and running tests using JUnit 5. Most Geode modules now support JUnit 5. For most Geode modules, you can now write each test class using either JUnit 5's "Jupiter" API or the legacy JUnit 4 API. Which modules support JUnit 5? Any source set th

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-12 Thread Robert Houghton
I would not call it a “surge” of them, but I perceived an uptick in them. From: Udo Kohlmeyer Date: Tuesday, October 12, 2021 at 1:00 PM To: dev@geode.apache.org Subject: Re: Geode-9621: Spotless overstepping its boundary of formatter I had never explicitly asked this, but what was the main driv

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-12 Thread Udo Kohlmeyer
I had never explicitly asked this, but what was the main driver for this ticket? Was there a surge in explicit version definitions in gradle files? I mean we as committers have agreed to using BOM constraints. --Udo From: Robert Houghton Date: Wednesday, October 13, 2021 at 4:32 AM To: dev@geo

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-12 Thread Robert Houghton
Again, Spotless is not changing code. That was a bad change, as you pointed out, and we modified Spotless to throw an exception instead of stripping out the version string indiscriminately. We surely could make Spotless only apply to the main source set. The cost would be that tests could use d

Re: Region is not created on one of the servers

2021-10-12 Thread Dan Smith
I think maybe a better option might be to use a lock for the cluster configuration. We can make the request to get the cluster config wait until the update to the cluster config is completely applied. Maybe we already have a lock to force cluster configuration updates to happen one at a time? -

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-12 Thread Dan Smith
>The formatter now throws when there is a naked version-string on the >dependency line, as we discussed. This new behavior seems reasonable to me. And I think this is what you are asking for, Udo? I do agree that spotlessApply shouldn't change any behavior and cause someone to lose part of thei

Odg: Region is not created on one of the servers

2021-10-12 Thread Mario Kevo
The new ticket is opened. https://issues.apache.org/jira/browse/GEODE-9718 There are two proposals on the ticket, so it should be decided in which way we should go. BR, Mario Šalje: Udo Kohlmeyer Poslano: 12. listopada 2021. 0:59 Prima: dev@geode.apache.org Pre