geode-benchmarks migrate to GH Action

2023-01-22 Thread Sai Boorlagadda
Could someone review and approve this PR? https://github.com/apache/geode-benchmarks/pull/170/files Sai

apiCheck - gradle task japicmp

2023-01-22 Thread Sai Boorlagadda
Could some one explain me what is this gradle task requirement? I see that we are running this japicmp only for JDK 11. Does it build using 11? Sai

Simple build pipeline for develop

2023-01-22 Thread Sai Boorlagadda
All, I would appreciate a review of this PR[1] that adds a GitHub action workflow to build and unit test develop and runs it on every PR to develop. This is just the beginning of this migration work and we would like to merge it as soon as possible. Will follow up with apiCheck and adding window

Pullrequest required checks

2023-01-22 Thread Sai Boorlagadda
Could someone have info regarding how the required checks are enabled on a Pull Request? In the process of setting up the Github Actions, I see there are still Concourse CI checks as "required" eg: on this PR[1] [1] https://github.com/apache/geode/pull/7870 Thanks Sai

Bad Practice: Static constant values set by system properties

2023-01-22 Thread Kirk Lund
Sai and I worked together yesterday and fixed almost all of the failing unit tests in the new build we're trying to set up. I think we have one failure remaining. Most of the failures we fixed turned out to be caused by new code that was committed to Geode in 2022 that causes values in static const