Cache.close is not synchronous?

I found a test that closes the cache and then recreates the cache multiple times with 2 second sleep between each. I tried to remove the Thread.sleep and found that recreating the cache throws DistributedSystemDisconnectedException (see below). This seems like a usability nightmare. Anyone have an

Re: [VOTE] Fix bad-merge of GEODE-7488

+1 adding my vote On Fri, Nov 22, 2019 at 11:56 AM Robert Houghton wrote: > I was overzealous in a merge to Geode, and got us into a chicken-and-egg > issue for PRs and reverts. Calling a vote to override the GitHub merge > button restriction via commiter privileges, to merge the fix in > https:

Re: [DISCUSS] is overriding a PR check ever justified?

Does everyone realize that you just voted NO to what now needs to be done for "[VOTE] Fix bad-merge of GEODE-7488"? So right now, if we do not override the PR check, we have no way to fix the PR checks. On Fri, Nov 22, 2019 at 11:56 AM Owen Nichols wrote: > Tallying the votes from this thread,

PR jobs failing to start

FYI: Looks like all PR test and build jobs are failing with: Warning: Permanently added '10.0.0.61' (ECDSA) to the list of known hosts. ServerAliveCountMax=5: No such file or directory capture-call-stacks.sh

Re: DistributionArchUnitTest OutOfMemoryError

> `./gradlew build` cause that would pass on the second time. > > > > -michael > > > > On Wed, Nov 20, 2019 at 4:53 PM Dan Smith wrote: > > > > > We recently added this test. It passes for me, but I will look into it. > > It > > > is scanning class

Re: [DISCUSS] - Move gfsh into its own submodule

+1 yes! On Fri, Nov 22, 2019 at 9:15 AM Donal Evans wrote: > +1 > > Especially with the new management functionality on the way, this seems > like a good idea. > > On Fri, Nov 22, 2019 at 8:45 AM Jinmei Liao wrote: > > > +100. Would be a great move. > > > > On Fri, Nov 22, 2019 at 8:40 AM Jens

DistributionArchUnitTest OutOfMemoryError

Any ideas why DistributionArchUnitTest would run OutOfMemoryError when doing a "./gradlew build"? I think we should move any unit tests that run OutOfMemoryError out of unit tests (to integration tests maybe?). > Task :geode:geode-core:test Heap dump file created [957877145 bytes in 17.227 secs]

Propose adding GEODE-7400 fix to 1.11 release

FederatingManager so that it invokes a supplier to get a new ExecutorService each time it is started to prevent the RejectedExecutionException. Co-authored-by: Aaron Lindsey Co-authored-by: Kirk Lund

Re: IncrementalBackupDistributedTest.testMissingMemberInBaseline hangs

On Wed, Nov 6, 2019 at 10:47 AM Kirk Lund wrote: > > > IncrementalBackupDistributedTest.testMissingMemberInBaseline is hanging > > intermittently in the DistributedTest job of CI and precheckin. > > > > I filed GEODE-7411 with all the involved thread stacks that I cou

IncrementalBackupDistributedTest.testMissingMemberInBaseline hangs

IncrementalBackupDistributedTest.testMissingMemberInBaseline is hanging intermittently in the DistributedTest job of CI and precheckin. I filed GEODE-7411 with all the involved thread stacks that I could find: https://issues.apache.org/jira/browse/GEODE-7411 If anyone knows of any recent changes

Re: ClassNotFoundException: org.apache.geode.logging.internal.log4j.api.LogService

n my daily work which means I'm writing acceptance tests every day AND you can't run these tests in IntelliJ without setting GEODE_HOME. On Mon, Nov 4, 2019 at 1:18 PM Kirk Lund wrote: > Looks like the Management service blows up > w

ClassNotFoundException: org.apache.geode.logging.internal.log4j.api.LogService

Looks like the Management service blows up with ClassNotFoundException: org.apache.geode.logging.internal.log4j.api.LogService This seems related to the previous ClassNotFoundException, except that in this instance, the LogService which cannot be found is in the correct package. Please disregard t

Re: ***UNCHECKED*** Re: ClassNotFoundException: LogService

bert Houghton wrote: > Kirk, will you craft a Jira about this for the "Build" component, and > assign it to me? > > On Mon, Nov 4, 2019, 09:30 Kirk Lund wrote: > > > If it is picking up an old version of geode then it's doing so because we > > use old versions f

Re: ***UNCHECKED*** Re: ClassNotFoundException: LogService

e picking up an old > version of one of the geode war files that is referring to the old location > of the LogService class. > > -Dan > > On Fri, Nov 1, 2019 at 3:28 PM Kirk Lund wrote: > > > To reproduce, drop this new test in geode-dunit/src/distributedTest/java > &g

Re: ClassNotFoundException: LogService

one of the geode war files that is referring to the old > location > > of the LogService class. > > > > -Dan > > > > On Fri, Nov 1, 2019 at 3:28 PM Kirk Lund wrote: > > > >> To reproduce, drop this new test in geode-dunit/src/distributedTest/java &

Re: ClassNotFoundException: LogService

lass. > > > > -Dan > > > > On Fri, Nov 1, 2019 at 3:28 PM Kirk Lund wrote: > > > >> To reproduce, drop this new test in geode-dunit/src/distributedTest/java > >> and then run it in IntelliJ or however you want. > >> > >> It pa

Re: ClassNotFoundException: LogService

est public void isRunning() { getVM(0).invoke(() -> { assertThat(locatorLauncher.isRunning()).isTrue(); }); } } On Fri, Nov 1, 2019 at 3:02 PM Kirk Lund wrote: > I'm seeing ClassNotFoundExceptions for FQN of the old package of the > LogS

ClassNotFoundException: LogService

I'm seeing ClassNotFoundExceptions for FQN of the old package of the LogService: [locator] Caused by: java.lang.ClassNotFoundException: *org.apache.geode.internal.logging.LogService* [locator] at java.net.URLClassLoader.findClass(URLClassLoader.java:382) The above is interesting because it's the

Re: [PSA] Github branch protection

3:02 PM Nabarun Nag wrote: > >>> > >>>> @Aaron : which PR are you referring to? I can only see "GEODE-7326: > Add > >>>> cache gets timers" which can be merged? I can get some more idea when > I > >> can > >>>> see whats

Re: [PSA] Github branch protection

One side effect is that any single request for changes will now completely block merging the PR. I'm not certain this was intentional? One rogue developer could block the merging of any or every PR. I'm not sure one person should have that much power... On Thu, Oct 24, 2019 at 2:25 PM Nabarun Nag

What tomcat8 is Geode using?

What actual artifacts does this refer to in DependencyConstraints.groovy? deps.put("tomcat8.version", "8.5.34") Does this mean we are using https://mvnrepository.com/artifact/org.apache.tomcat/tomcat-catalina/8.5.34 or some download?

Re: [DISCUSS] log4j errors/warnings

ttps://github.com/spring-projects/spring-boot-data-geode/blob/master/spring-geode-docs/src/main/resources/logback.xml#L4 > > > On Tue, Oct 22, 2019 at 9:57 AM Xiaojian Zhou wrote: > > > I hit this problem in PR. I am just curious why it did not happen before? > > > > >

Re: [DISCUSS] log4j errors/warnings

ly and incorrectly > > changed by some maintainer later on. > > > > $0.02 > > > > -j > > > > > > [1] > > > > > https://github.com/spring-projects/spring-boot-data-geode/blob/master/spring-geode-docs/src/main/resources/logback.xml#L4 > &g

DistributedTestOpenJDK8 timing out

DistributedTestOpenJDK8 is timing out here-and-there in CI and precheckin runs. When was the last time we increased the timeout for this job? Anyone want to increase it now?

Re: [DISCUSS] log4j errors/warnings

I'm ok with adding log4j-core to the testRuntime for all unit test targets to prevent the ERROR message. Any other input? On Fri, Oct 18, 2019 at 3:10 PM John Blum wrote: > Be careful to only add logging dependencies as testRuntime dependencies. > Do not add any logger implementation/provider (e

Please review PR #4190

ServerLauncherTest is failing in CI because port 40404 is in use on the machine. The tests that are failing are unit tests and do not require starting a CacheServer on port 40404. Please review PR #4190 which disables the default server in these unit tests. https://github.com/apache/geode/pull/419

Re: [PROPOSAL] adding java-jq to GEODE dependency for testing

I would prefer we stick to one family of libraries for JSON. So, if there's a comparable release from Jackson, then I think we should go with that instead. On Wed, Sep 25, 2019 at 12:55 PM Owen Nichols wrote: > The Jackson-jq project actually imports the full testsuite from the “real" > jq proje

Re: New geode-log4j module

Please review https://github.com/apache/geode/pull/4089 for the fix. Thanks, Kirk On Tue, Sep 24, 2019 at 1:17 PM Kirk Lund wrote: > It's a race condition in how GfshRule, GfshExecution, and ProcessLogger > fork a process before attaching the stdout and stderr listeners. The &g

Re: New geode-log4j module

en be back to consistently green On Tue, Sep 24, 2019 at 12:23 PM Kirk Lund wrote: > It's not a problem in TomcatInstall. Nothing obvious anywhere. Even the > output that GfshRule says is missing the string actually does contain the > missing text. I have no idea why this passed in

Re: New geode-log4j module

It's not a problem in TomcatInstall. Nothing obvious anywhere. Even the output that GfshRule says is missing the string actually does contain the missing text. I have no idea why this passed in precheckin but fails now... On Tue, Sep 24, 2019 at 11:16 AM Kirk Lund

Re: New geode-log4j module

d-versions subproject to preserve the full version string (with periods) for older versions. This lets the tomcat test build a classpath without requiring the target version to have representation in Version.java. On Tue, Sep 24, 2019 at 10:24 AM Kirk Lund wrote: > All classes that us

New geode-log4j module

using *-Dclasspath* (or other proprietary/environment options) in *Gradle VM options*. The commit on develop: commit efc2362d2bae0877a427ce2c29beae94118d6567 Author: Kirk Lund Date: Thu Aug 8 15:17:54 2019 -0700 GEODE-6964: Move geode log4j core classes to geode-log4j Introduce new Logging

Re: [DISCUSS] - Cutting of release 1.9.2

+1 for creating 1.9.x with the fix for GEODE-7121 On Fri, Sep 20, 2019 at 1:09 PM John Blum wrote: > Hi Kirk - SDG 2.3/Neuman, which is only after SDG 2.2/Moore GAs, which is > tentatively scheduled for Monday, Sept. 30th. > > On Fri, Sep 20, 2019 at 1:01 PM Kirk Lund wrote: >

Re: [DISCUSS] - Cutting of release 1.9.2

Hi Udo, SDG cannot upgrade to Geode 1.10.x until which version? SDG 2.2.0? On Fri, Sep 20, 2019 at 12:45 PM Udo Kohlmeyer wrote: > Hi there Geode Dev's, > > I would like to propose a release for Geode 1.9.x that includes > https://issues.apache.org/jira/browse/GEODE-7121. > > This is an issue th

Please review PR #4071

Can I please get a couple reviews of PR #4071? GEODE-7165: Remove networking dependency from GatewayReceiverImplTest #4071 https://github.com/apache/geode/pull/4071 Thanks, Kirk

Please review PR #4024

Please review PR #4024 https://github.com/apache/geode/pull/4024 The purpose of this PR is to reduce flaky failures involving ServerLauncher tests.

Re: [VOTE] Apache Geode 1.10.0.RC1

tualSerializables.dat > and if you remove them from sanctioned-geode-core-serializables.txt > testSerializables passes but testSanctionedClassesExistAndDoDeserialize > fails. > > Regards > Naba > > > On Thu, Sep 5, 2019 at 3:21 PM Kirk Lund wrote: > > > Hi Naba, > > >

Re: [VOTE] Apache Geode 1.10.0.RC1

Hi Naba, I failed to reproduce the problem you reported on Mac OS, and our pipeline didn't fail this test. What OS are you running integrationTest on? Here's the steps I followed: 1) checkout tag rel/v1.10.0.RC1 $ git checkout tags/rel/v1.10.0.RC1 2) clean, then build with unit tests $ ./gradl

Re: [VOTE] Apache Geode 1.9.1.RC3

0.x) is in this commit: *commit 81e52443445fef3745f4249c1eb08e1a19f7392eAuthor: Kirk Lund >Date: Thu Apr 11 16:20:50 2019 -0700GEODE-6618: Remove PartitionedRegionLoadModelJUnitTest etc hosts dependency (#3435)* I simply changed the test to use *SocketCreator.getLocal

Re: [VOTE] Apache Geode 1.10.0.RC1

+1 to release 1.10.0.RC1. Downloaded and reviewed contents of artifacts. Reviewed Manifest of geode dependency jar. Used GFSH to start locator and server. On Wed, Sep 4, 2019 at 4:14 PM Dick Cavender wrote: > We manually signed the apache-geode-1.10.0-src.tgz dist and uploaded the > asc file. >

Re: [DISCUSS] RFC - Move membership code to a separate gradle sub-project

*interfaces -> was supposed to be "implementations" On Thu, Sep 5, 2019 at 9:33 AM Kirk Lund wrote: > +1 The planned subprojects look good. Thanks for clarifying the > goals/anti-goals in the RPC, especially the anti-goal to not make it > pluggable with different interfa

Re: [DISCUSS] RFC - Move membership code to a separate gradle sub-project

+1 The planned subprojects look good. Thanks for clarifying the goals/anti-goals in the RPC, especially the anti-goal to not make it pluggable with different interfaces. On Thu, Sep 5, 2019 at 8:52 AM Aaron Lindsey wrote: > +1 — I'm happy to see us move toward better testability for the membersh

Re: [VOTE] Apache Geode 1.9.1.RC3

+1 to release RC3. Downloaded and reviewed contents of artifacts. Reviewed Manifest of geode dependency jar. Used GFSH to start locator and server. On Wed, Sep 4, 2019 at 11:50 AM Dave Barnes wrote: > +1 > checked the geode-native package by successfully building the library and > the api docs.

Re: [VOTE] Apache Geode 1.9.1.RC3

Everything looks good to me other than the empty apache-geode-native-1.9.1-src.tar.gz file. On Tue, Sep 3, 2019 at 2:09 PM Dan Smith wrote: > It looks like the native source is missing from this RC? There is a tar > file, but it is emply if you try to unzip it. > > -Dan > > On Fri, Aug 30, 2019

Re: [VOTE] Apache Geode 1.9.1.RC3

Hi John, Unfortunately, that ERROR message is logged by Log4J, not Geode. The only way to prevent it or turn it off is to provide a logging implementation. Putting Logback plus Log4j 2 to SLF4J Adapter on the classpath should be sufficient to make Log4J happy. On Tue, Sep 3, 2019 at 10:40 AM John

Re: [VOTE] Apache Geode 1.9.1 RC2

+1 On Thu, Aug 29, 2019 at 5:02 PM Owen Nichols wrote: > Hello Geode dev community, > > This is a release candidate for Apache Geode, version 1.9.1.RC2. > Thanks to all the community members for their contributions to this > release! > > Please do a review and give your feedback. The deadline is

Re: [VOTE] Apache Geode 1.9.1 RC1 (new vote)

We submitted a PR against release/1.9.1 to remove 1.9.1 from Version: https://github.com/apache/geode/pull/3989 Please review. After we merge this in, we'll create RC2 and start a vote for it. Thanks, Kirk and Owen On Thu, Aug 29, 2019 at 1:53 PM Kirk Lund wrote: > Anyone want to

Re: [VOTE] Apache Geode 1.9.1 RC1 (new vote)

Anyone want to help me revert these Version changes and make an RC2? I'm not sure how to do this correctly. On Thu, Aug 29, 2019 at 1:48 PM Kirk Lund wrote: > Deadline for voting is Sept 5th. However, we have two -1 votes so RC1 is > dead. > > @John I'm not sure we can mak

Re: [VOTE] Apache Geode 1.9.1 RC1 (new vote)

hange on this branch and on > develop > > > On 8/29/19 9:02 AM, Kirk Lund wrote: > > Hello Geode dev community, > > > > This is a release candidate for Apache Geode, version 1.9.1.RC1. > > Thanks to all the community members for their contributions to this > re

Re: [VOTE] Apache Geode 1.9.1 RC1 (new vote)

+1 (just in case my vote counts) On Thu, Aug 29, 2019 at 9:02 AM Kirk Lund wrote: > Hello Geode dev community, > > This is a release candidate for Apache Geode, version 1.9.1.RC1. > Thanks to all the community members for their contributions to this > release! > > Please

[VOTE] Apache Geode 1.9.1 RC1 (new vote)

de-examples: ./gradlew -PgeodeReleaseUrl= https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC1 -PgeodeRepositoryUrl= https://repository.apache.org/content/repositories/orgapachegeode-1055 build runAll Regards Owen Nichols & Kirk Lund

Re: [VOTE] Apache Geode 1.9.1 RC1

/apache/geode/blob/develop/KEYS> > > > > PS: Command to run geode-examples: ./gradlew -PgeodeReleaseUrl= > https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC1 < > https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC1> > -PgeodeRepositoryUrl= > https://repository.apache.org/content/repositories/orgapachegeode-1055 < > https://repository.apache.org/content/repositories/orgapachegeode-1055> > build runAll > > > > Regards > > Owen Nichols & Kirk Lund > > > >

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

Let's reopen the vote! On Wed, Aug 28, 2019 at 1:49 PM Kirk Lund wrote: > Do folks actually want a 1.9.1 release? > > On Wed, Aug 28, 2019 at 1:38 PM Owen Nichols wrote: > >> The VOTE for 1.9.1.RC1 failed due to lack of quorum, so re-opening this >> thread to cont

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

aker wrote: > > > > Yep. Get a release manager, identify and cherry pick all the changes, > then do the release. > > > > Anthony > > > >> On Aug 16, 2019, at 4:21 PM, Kirk Lund wrote: > >> > >> Does anyone know what the next step is? Do

Re: [DISCUSS] Version 1.11 serialization ordinal is wrong

I think they did that because the datatypes in the Version class are too small. I'm not sure why bytes and shorts were chosen. The version constants are defined as bytes: private static final *byte* GEODE_1_11_0_ORDINAL = 107; While the ordinal is defined as a short: private final *short* ordin

Re: Gradle daemon crashed in PR precheckin

e Gradle daemon in > CI, > >> so we could use the --no-daemon flag to disable the Gradle daemon in CI > if > >> we feel that would help eliminate extra problems. > >> > >> -michael > >> > >>> On Thu, Aug 22, 2019 at 10:36

Gradle daemon crashed in PR precheckin

Can someone please look at https://concourse.apachegeode-ci.info/builds/88869 and help me determine what happened to the Gradle daemon? > Task :geode-assembly:distributedTest > Task :geode-core:distributedTest

Re: Need help: Jetty dunit tests blocking creation of geode-log4j

vm-crashes-with-error-cannot-allocate-memory-errno-12 On Wed, Aug 21, 2019 at 8:36 AM Jens Deppe wrote: > I can work with you on this if you're still blocked. > > --Jens > > On Tue, Aug 20, 2019 at 4:12 PM Kirk Lund wrote: > > > Does anyone know how to debug geo

Integration tests on Windows in 1.9.0

There are several integration tests failing on Windows in our potential branch for 1.9.1. *Does anyone know if integration tests were GREEN on Windows in 1.9.0?* AvailablePortHelperIntegrationTest and BackupIntegrationTest seem to fail consistently on Windows. ServerLauncherRemoteFileIntegrationT

Need help: Jetty dunit tests blocking creation of geode-log4j

Does anyone know how to debug geode-assembly Jetty dunit tests that fail to launch modify_war? It passes 100% locally in intellij and with gradle cli. It only fails in concourse PR precheckin. Right now, this is the last thing blocking me from submitting a non-draft PR to move all log4j-core code

Re: [DISCUSS] Controlling event dispatch to AsyncEventListener (review by Aug 22)

If we need to add pause/resume processing to Cache, I suggest adding setAutostart(boolean) to CacheFactory and start() to Cache to do something like this: Cache cache = new CacheFactory() *.setAutostart(false)* .create(); cache.createRegionFactory(...)... cache.createAsyncEventQueu

Re: [DISCUSS] what region types to support in the new management rest api

Here's my 2cents: The Geode Management REST API should definitely support "group" such that creation of a region may target zero, one, or more groups. On Tue, Aug 20, 2019 at 10:45 AM Darrel Schneider wrote: > Is "group" support on the PCC roadmap or is the plan for the members of a > cluster to

Re: Hardcoded list of jars for Jetty tests

j", "geode-management", "javax.transaction-api", "jgroups", "log4j-api", "log4j-core", "log4j-jul", "micrometer", "shiro-core", "jetty-server", "jetty-util", "jetty-http"

Hardcoded list of jars for Jetty tests

Can anyone point me at the hardcoded list of jars for the Jetty and Tomcat tests? I can't seem to find it this time despite grepping for several things that should be in the list. Maybe it was changed since I last had to look for it... I found the one in dunit ProcessManager: dunitClasspath

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

On Aug 16, 2019, at 4:21 PM, Kirk Lund wrote: > > > > Does anyone know what the next step is? Do we need a release manager to > > proceed? > > > >> On Tue, Aug 13, 2019 at 1:57 PM John Blum wrote: > >> > >> Sorry, corrections below... > &g

Re: I propose including the fix for GEODE-3780 in 1.10

+1 On Mon, Aug 19, 2019 at 8:29 AM Alexander Murmann wrote: > +1 > > it's a regression in 1.10 and a serious problem. > > On Mon, Aug 19, 2019 at 7:38 AM Bruce Schuchardt > wrote: > > > It sounds like Udo is okay with this now. Any other concerns? > > > > On 8/17/19 2:07 AM, Owen Nichols wrote

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

ects/spring-data-geode/blob/2.1.10.RELEASE/pom.xml#L25 > >> [8] > >> > https://github.com/jxblum/spring-boot-data-geode/blob/1.2.x/gradle.properties#L8 > >> [9] > >> > https://github.com/jxblum/spring-boot-data-geode/blob/1.2.x/gradle.properties#L12 > &

Re: Propose fix for 1.10 release: Prevent NPE in getLocalSize()

Done! On Thu, Aug 15, 2019 at 3:21 PM Dan Smith wrote: > @kirk - go ahead and push it. > > -Dan > > On Thu, Aug 15, 2019 at 3:13 PM Kirk Lund wrote: > > > I have the cherry-pick ready to push or file a PR. Let me know what you > > prefer... > > > >

New build warnings

Just a reminder, that our many sun.misc.* warnings are drowning out real warnings... We are adding new build warnings which makes me sad. This one was added recently: /Users/klund/dev/geode3/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java:1075: warning: unr

Re: Propose fix for 1.10 release: Prevent NPE in getLocalSize()

as reverting GEODE-7001 would be more effort :) > > >> > > >> --Udo > > >> > > >> On 8/14/19 9:25 AM, Aaron Lindsey wrote: > > >>> @Udo, I think Kirk explained it well — This issue was introduced very > > recently (right befo

Re: Propose fix for 1.10 release: Prevent NPE in getLocalSize()

+1 to include this fix in 1.10.0 FYI: The race condition for this code path to throw NPE (which is catastrophic and requires restarting the server) was introduced by commit 279fa0 on July 31 for GEODE-7001. On Tue, Aug 13, 2019 at 6:22 PM Anthony Baker wrote: > Given that we’re trying to stabil

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

by (whether > we do a 1.9.1 release or 1.10 release)? > > > > - Aaron > > > >> On Aug 13, 2019, at 9:31 AM, Bruce Schuchardt > wrote: > >> > >> If we release a 1.9.1 I'd like to include the SSL/NIO fix. Cluster SSL > communications with co

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

to bring it to the > 1.10.0 > > > release branch. > > > > > > -Owen > > > > > > > On Aug 8, 2019, at 10:54 AM, Kirk Lund wrote: > > > > > > > > I'd like to propose including the fix for GEODE-6959 in 1.10.0.

[DISCUSS] Release Geode 1.9.1 with logging improvements

The specific tickets and commits that would be back-ported are: *1. GEODE-7058 Log4j-core dependency should be optional in geode-core* commit 413800bc16d05df689a2af5c30797f180aad6088 Author: Kirk Lund Date: Wed Aug 7 14:33:21 2019 -0700 GEODE-7058: Mark log4j-core optional in geode

Re: Unit tests are hanging?

Thanks Owen! On Sat, Aug 10, 2019 at 1:53 PM Owen Nichols wrote: > Done (increased from 10 minutes to 20 minutes for PR pipeline, and changed > from none to 20 minutes for develop pipeline). > > -Owen > > > On Aug 10, 2019, at 11:01 AM, Kirk Lund wrote: > > > >

Re: Unit tests are hanging?

1:28 AM Ryan McMahon wrote: > > > Looks like we have a general consensus from the community. I'll go ahead > > and make a PR for the changes. > > > > Thanks, > > Ryan > > > > On Thu, Aug 8, 2019 at 11:03 AM Juan José Ramos > wrote: > > &

Re: SSL Alias Support for JMX Connections

+1 On Fri, Aug 9, 2019 at 9:38 AM Jason Huynh wrote: > +1 > > On Thu, Aug 8, 2019 at 7:12 PM Owen Nichols wrote: > > > Hi Juan and Sai, thank you for bringing your concern. > > > > Geode's release process dictates a time-based schedule < > > https://cwiki.apache.org/confluence/display/GEODE/Rel

Fix for ClassCastException when using Logback for 1.10.0

This is the last logging related fix that I'd like to propose adding to 1.10.0 release branch. Spring Boot adds Logback and log4j-to-slf4j to the classpath. This results in ClassCastExceptions if log4j-core is not excluded. This change prevents Geode from using Log4jAgent if Log4j Core is present

Re: Unit tests are hanging?

+1 On Thu, Aug 8, 2019 at 10:14 AM Dan Smith wrote: > > With all that, I propose we permanently bump the timeouts on UnitTestX > jobs > > across the board (main pipeline, PR pipeline, etc) from 10 to 20 minutes > to > > be more tolerant of these types of degradations. > > > > +1 > > -Dan >

Fix for NPE during forceDisconnect candidate for 1.10.0

I'd like to propose including the fix for GEODE-6959 in 1.10.0. Spring Boot users are very likely to hit this NPE during forceDisconnect. If a custom log4j2.xml is used without specifying the Geode AlertAppender, GMSMembershipManager may throw a NullPointerException when invoking AlertAppender.ge

Re: Unit tests are hanging?

> > at sun.rmi.transport.Transport$1.run(Transport.java:197) > > at java.security.AccessController.doPrivileged(Native Method) > > at sun.rmi.transport.Transport.serviceCall(Transport.java:196) > > at > sun.rmi.transport.tcp.TCPTransport.handleMe

Re: ./gradlew test no longer runs/reruns tests?

wrote: > We added a property to force test reruns specifically, but I can't remember > it off hand. More generally, is a gradle option to rerun all tasks (but > this takes longer) '--rerun-tasks'. > > On Wed, Aug 7, 2019, 10:09 Kirk Lund wrote: > > > I used

./gradlew test no longer runs/reruns tests?

I used to use "./gradlew test" to run or rerun unit tests but it no longer works. It seems to just early out... maybe gradle thinks that the unit tests were already run so it doesn't need to rerun them. Is this intentional? I assume some gradle changes were made that changed this behavior.

Re: Unit tests are hanging?

lly. Let me see if I can get them to > show up…it might have something to do with the logging level. > > > On Aug 7, 2019, at 12:45 PM, Kirk Lund wrote: > > > > I don't know if the PowerMock warnings are related but that's the only > > thing interesting i

Re: Unit tests are hanging?

CIO duty a couple days ago, I remember seeing this warning in a > failing build, but then I looked back at passing builds on saw this as well. > > > On Aug 7, 2019, at 12:40 PM, Kirk Lund wrote: > > > > The build is broken in CI right now (for main CI and PRs). The UnitTest

Unit tests are hanging?

The build is broken in CI right now (for main CI and PRs). The UnitTest jobs are timing out so I assume there's a hang of some sort. The WARNINGs appear to be related to PowerMock and begins with "An illegal reflective access operation" in geode-assembly:test. I'm running unit tests locally and h

Re: [DISCUSS] Time to cut Geode 1.10.0?

Did we already cut the 1.10 branch? I'd like to find out if it's possible to get a change into 1.10: Upgrade log4j from 2.11.1 to 2.12.0 and mark log4j-core as an optional dependency in the geode-core pom. Getting this change into 1.10 will make things much easier for Spring Boot Data Geode. When

Re: edit permissions on wiki

Oops. Try now. On Fri, Aug 2, 2019 at 12:52 PM Joris Melchior wrote: > Don't seem to have edit permissions yet though ... > > On Fri, Aug 2, 2019 at 3:48 PM Joris Melchior > wrote: > > > Thanks Kirk! > > > > On Fri, Aug 2, 2019 at 12:16 PM Kirk Lund wrot

Re: edit permissions on wiki

You should have permission now. Thanks! On Fri, Aug 2, 2019 at 7:32 AM Joris Melchior wrote: > Hi, > > Can someone provide me with edit permissions on the wiki? Specifically the > tree starting with this link > > https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service > > My

Re: PR reviews

Is there anyone who knows enough about security and JMX to review PR #3697 (GEODE-6717 NotAuthorizedException during JMX scraping)? Jinmei is out on PTO until mid next week. On Mon, Jul 29, 2019 at 1:51 AM Mario Kevo wrote: > Hi Geode dev, > > We need some PR reviewers on the following PRs. Some

Re: PR reviews

I'll add my review later today. Thanks for the reminder! On Mon, Jul 29, 2019 at 1:51 AM Mario Kevo wrote: > Hi Geode dev, > > We need some PR reviewers on the following PRs. Some of these just need > to be *re*-reviewed. > > GEODE-6998 NPE during update of index due to GII > https://github.com/

Need reviewers for #3762: prevent creation of unnecessary PartitionedRegion callback events

We need reviewers for PR #3762 -- no one has reviewed it yet: https://github.com/apache/geode/pull/3762 Looks like it involves optimizing PartitionedRegion callback events to prevent creation of events that will just become garbage because there are no listeners to receive those events. Jira tick

Re: Naming System for Regions - Active Jira Question

Sorry, Alex! Pick another :) On Mon, Jul 15, 2019 at 3:39 PM Kirk Lund wrote: > I went ahead and closed out the ticket as "won't fix". Below is my > explanation: > > Changing region names to not be case sensitive would break backwards > compatibility for existing

Re: Naming System for Regions - Active Jira Question

I went ahead and closed out the ticket as "won't fix". Below is my explanation: Changing region names to not be case sensitive would break backwards compatibility for existing users. It's better for a given user to devise a standard naming scheme for regions to avoid any issues caused by trying to

Re: [Proposal] Refactor the Cache and Region perf stats structure.

I would recommend doing a spike for this refactoring before trying to provide a class diagram -- I would personally learn a lot that would have a major effect on the resulting class design that I can only guess about up front. Another major challenge is in trying to keep the resulting .gfs file un

Pair of gists showing example regression tests

I wrote this up to help out a contributor with a pull request and thought it might interest others as well. The ticket is GEODE-3718 The InternalResourceManager fails to shutdown if a redundancy recovery task is scheduled but hasn't fired yet I'v

Re: Unnecessary uses of final on local variables

Just to *wrap up* this thread: *I'm with-drawing my proposal.* We do not have any sort of consensus (rough or otherwise) regarding the use of final on local variables. Thanks to everyone who participated! On Thu, Jun 13, 2019 at 1:31 PM Kirk Lund wrote: > According to Effective

Re: [DISCUSS] Adoption of a Coding Standard

h longer than that, it > becomes burdensome to read for newcomers and we want to make sure they can > quickly take in what's most important. > > I also prefer "guidelines" over "rules". I'd like to have a discussion if > someone is not following a guidelin

Re: [DISCUSS] Adoption of a Coding Standard

you would recommend over this one? On Mon, Jun 24, 2019 at 2:45 PM Anthony Baker wrote: > What did you like about the SEI rules you suggested? I’m wondering why > _that_ one versus all the others in the universe? > > Anthony > > > > On Jun 24, 2019, at 2:15 PM, Kirk Lund

[DISCUSS] Adoption of a Coding Standard

Apache Geode has a Code Style Guide [1] which is currently defined as following the Google Java Style Guide [2]. This style guide is a good starting point, but it deals primarily with formatting of code and is a fairly dated and static document that doesn't evolve much. I'd like to propose that th

<    1   2   3   4   5   6   7   8   9   10   >