Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/737#discussion_r134890133
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -58,6 +58,7 @@ message GetAllRequest {
message GetAllResponse {
repeated
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133599245
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133598920
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -50,51 +37,19
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133596280
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -334,42 +342,46 @@ protected void run
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133597359
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
---
@@ -0,0 +1,64
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133598026
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133595959
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -120,6 +126,7 @@
private InetAddress
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133596604
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java ---
@@ -76,7 +76,9 @@
*/
public interface InternalCache
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133597935
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/714
GEODE-3412: adding files missing from last commit
This is adding some files which should have been in the last commit for
this feature.
Thank you for submitting a contribution to Apache
Github user WireBaron closed the pull request at:
https://github.com/apache/geode/pull/713
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/713
Feature/geode 3412
This is adding some files which should have been in the last commit for
this feature.
Thank you for submitting a contribution to Apache Geode.
In order
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133230687
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -144,35 +156,22 @@ private boolean isClosed() {
* called
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133230527
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads() {
return
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/700#discussion_r132591028
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
---
@@ -41,9 +42,8
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/700#discussion_r132591701
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
---
@@ -28,6 +28,8 @@
import
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/700#discussion_r132591361
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
---
@@ -59,13 +59,14
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/700#discussion_r132591888
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
---
@@ -79,9 +81,10
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/707
GEODE-3412: Add simple authentication flow to protobuf protocol.
@pivotal-amurmann @galen-pivotal @kohlmu-pivotal @bschuchardt @hiteshk25
This change adds a simple username/password
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131287954
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -302,14 +302,14 @@ boolean checkForExpiration
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131287871
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -87,7 +87,8 @@
private Thread thread
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131287366
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java
---
@@ -196,6 +196,13 @@ long getLeaseExpireTime
Github user WireBaron commented on the issue:
https://github.com/apache/geode/pull/676
Rebased to fix conflicts and added an error code to the new
GetAvailableServers handler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/676
GEODE-3321: Adding ErrorCode values to protobuf protocol
@pivotal-amurmann @kohlmu-pivotal @hiteshk25 @galen-pivotal @bschuchardt
Signed-off-by: Bruce Schuchardt <bschucha...@pivotal
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/673
GEODE-3284: New flow: getAvailableServers
@galen-pivotal @kohlmu-pivotal @bschuchardt @hiteshk25 @pivotal-amurmann
Signed-off-by: Bruce Schuchardt <bschucha...@pivotal.io>
Github user WireBaron commented on the issue:
https://github.com/apache/geode/pull/657
Pushed a new revision tightening the check before adding a connection to
the connectionTable's receivers.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129961462
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ---
@@ -1322,6 +1328,14 @@ private void createBatchSendBuffer
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129961225
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java ---
@@ -279,26 +280,29 @@ protected void acceptConnection(Socket sock
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/661
GEODE-3319 - refactor to use protobuf encoding for primitive types
@pivotal-amurmann @galen-pivotal @hiteshk25 @kohlmu-pivotal @bschuchardt
This changes protobuf EncodedValue messages
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129683975
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ---
@@ -1322,6 +1328,14 @@ private void createBatchSendBuffer
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129683563
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ---
@@ -568,6 +568,12 @@ protected Connection(ConnectionTable t, Socket
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/657
GEODE-3286: Failing to cleanup connections from ConnectionTable receiâ¦
â¦ver table
@kohlmu-pivotal @galen-pivotal @pivotal-amurmann @bschuchardt @hiteshk25
- prevent adding
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r128652774
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -62,4 +62,14 @@ message Region {
message Server {
string url = 1
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128591891
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Result.java
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128597628
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Failure.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128600182
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
---
@@ -15,32 +15,35 @@
package
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/643
GEODE-3192,GEODE-3229: Change API and implementation of protobuf PutAll.
@kohlmu-pivotal @pivotal-amurmann @galen-pivotal @bschuchardt @hiteshk25
* We will now dispatch incoming protobuf
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/632
GEODE-3203: fixing protobuf build.gradle to respect buildRoot
Signed-off-by: Bruce Schuchardt <bschucha...@pivotal.io>
Thank you for submitting a contribution to Apache
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127299289
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
---
@@ -14,6 +14,14
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127292855
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
---
@@ -14,6 +14,14
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127290974
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127285451
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
---
@@ -33,7 +33,7
Github user WireBaron commented on the issue:
https://github.com/apache/geode/pull/631
Isn't it the same code handling the SSL handshake for both protocols right
now? If it's a different code path, then we should probably add a new test
for it.
On Thu, Jul 13, 2017
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/631
GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept
This removes handling of SSL exceptions from the AccepterImpl.accept call,
as the SSL handling code is now all done
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/629
GEODE-2997: New flow getAll/putAll
Changed get response to indicate if LookupFailure was a missing key or key
with null value, added test
Added GetAllRequestOperationHandler and unit test
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/621
GEODE-3129 - Added error messages to protobuf protocol
added a new ErrorResponse type to ClientProtocol
removed success field from several RegionAPI response objects and
refactored operation
Github user WireBaron closed the pull request at:
https://github.com/apache/geode/pull/617
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/617
GEODE-3129 - Added error messages to protobuf protocol
added a new ErrorResponse type to ClientProtocol
removed success field from several RegionAPI response objects and
refactored operation
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/612
GEODE-3121: ensure that the protobuf protocol works over SSL
This just introduces a new test where we run the put/get integration test
of the protocol module, but sets up a SSL cache and socket
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/607
GEODE-3105: adding GetRegion handler for protobuf protocol
Added a handler which will catch incoming getRegion requests and will call
into the cache's rootRegion and return the names of the region
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/605
GEODE-2996: incorporating review feedback and adding integration test
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/602
GEODE-3130: Refactoring AcceptorImpl
We extracted a switch statement in AcceptorImpl.handleNewClientConnection
to a new method.
Signed-off-by: Alexander Murmann <amurm...@pivotal
Github user WireBaron closed the pull request at:
https://github.com/apache/geode/pull/593
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user WireBaron commented on the issue:
https://github.com/apache/geode/pull/567
This work is being handled as part of a larger refactor effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user WireBaron closed the pull request at:
https://github.com/apache/geode/pull/567
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/567
GEODE-3051: Removing obsolete SSL handling in `AcceptorImpl.accept` câ¦
â¦atch block
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review
56 matches
Mail list logo
