GitHub user dihardman opened a pull request:
https://github.com/apache/geode-examples/pull/10
Feature/geode 3202
Here is a new simple example that uses Lucene indexes and searching. Please
review and comment.
You can merge this pull request into a Git repository by running
Github user dihardman commented on the issue:
https://github.com/apache/geode/pull/555
+1 Looks good. Thanks!
On Fri, Jun 2, 2017 at 9:26 AM, Karen Miller
wrote:
> @dihardman <https://github.com/dihardman> @boglesby
> <https://github.com/bogle
Github user dihardman commented on the issue:
https://github.com/apache/geode/pull/554
+1
On Wed, May 31, 2017 at 4:24 PM, Karen Miller
wrote:
> @joeymcallister <https://github.com/joeymcallister> @dihardman
> <https://github.com/dihardman>
Github user dihardman commented on the issue:
https://github.com/apache/geode/pull/544
+1, looks good.
On Wed, May 31, 2017 at 2:46 PM, Barrett Oglesby
wrote:
> *@boglesby* approved this pull request.
>
> â
> You are receiving this beca
Github user dihardman commented on the issue:
https://github.com/apache/geode/pull/553
+1 looks good!
On Wed, May 31, 2017 at 1:33 PM, Karen Miller
wrote:
> @dihardman <https://github.com/dihardman> @boglesby
> <https://github.com/boglesby>
Github user dihardman commented on a diff in the pull request:
https://github.com/apache/geode/pull/544#discussion_r119445495
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -294,8 +294,11 @@ will return `object_2`.
will return `object_3
Github user dihardman commented on a diff in the pull request:
https://github.com/apache/geode/pull/544#discussion_r119445110
--- Diff:
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running
Github user dihardman commented on a diff in the pull request:
https://github.com/apache/geode/pull/544#discussion_r119439870
--- Diff:
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running
Github user dihardman commented on a diff in the pull request:
https://github.com/apache/geode/pull/544#discussion_r119438727
--- Diff:
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running
Github user dihardman commented on the issue:
https://github.com/apache/geode/pull/550
+1, thanks the new description is more accurate.
On Tue, May 30, 2017 at 2:12 PM, Dave Barnes
wrote:
> *@davebarnes97* approved this pull request.
>
>
Github user dihardman commented on the issue:
https://github.com/apache/geode/pull/545
+1 Looks good!
On Fri, May 26, 2017 at 3:15 PM, Karen Miller
wrote:
> @DivineEnder <https://github.com/divineender> @upthewaterspout
> <https://github.com/
Github user dihardman commented on the issue:
https://github.com/apache/geode/pull/542
+1 - Looks fine to me.
On Fri, May 26, 2017 at 12:30 PM, Dave Barnes
wrote:
> *@davebarnes97* approved this pull request.
>
> LGTM +1
>
> â
Github user dihardman commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117387903
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -219,7 +219,7 @@ at TestClient.main(TestClient.java:59)
```
- If the
13 matches
Mail list logo
