Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/745#discussion_r135639047
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/security/TestCommand.java
---
@@ -171,28 +171,37 @@ private static void init
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/745#discussion_r135634811
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommand.java
---
@@ -794,7 +84,7 @@ public Result
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/745#discussion_r135633281
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExecuteFunctionCommand.java
---
@@ -156,7 +132,7 @@ public Result
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/745#discussion_r135629055
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
---
@@ -247,7 +207,7 @@ public Result
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/745#discussion_r135597926
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateDefinedIndexesCommand.java
---
@@ -0,0 +1,155
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134804772
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
---
@@ -147,11 +147,10 @@ public ResultData
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134616035
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
---
@@ -147,11 +147,10 @@ public ResultData
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132483129
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalIntegrationTest.java
---
@@ -14,745 +14,270 @@
*/
package
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132515331
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java ---
@@ -810,9 +819,6 @@ public void setStatus(final String
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132520010
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/StartupStatus.java
---
@@ -14,29 +14,37 @@
*/
package
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132501696
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/mbean/Process.java
---
@@ -16,7 +16,6 @@
/**
* Extracted from
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132497014
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,182
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132325049
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1075,8 +1082,7 @@ private LocatorState
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132303567
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderWindowsTest.java
---
@@ -0,0 +1,97
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132314371
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132314473
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132315473
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132304059
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,179
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132314337
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132301005
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132291477
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132287600
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132285291
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132281558
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java
---
@@ -47,26 +50,21 @@
@Before
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/687#discussion_r131787137
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ValidateDiskStoreCommand.java
---
@@ -0,0 +1,107
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/687#discussion_r131787085
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/UpgradeOfflineDiskStoreCommand.java
---
@@ -0,0 +1,179
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/687#discussion_r131785934
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListDiskStoreCommand.java
---
@@ -0,0 +1,120
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/687#discussion_r131782938
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactOfflineDiskStoreCommand.java
---
@@ -0,0 +1,178
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/687#discussion_r131777554
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CompactDiskStoreCommand.java
---
@@ -0,0 +1,185
Github user pdxrunner commented on the issue:
https://github.com/apache/geode/pull/687
I'll go ahead and review your command refactorings in this PR, keeping in
mind that the test will be dealt with under the other JIRA. I agree with not
changing those two DUnit tests at this
Github user pdxrunner commented on the issue:
https://github.com/apache/geode/pull/687
With regards to your comments on the test classes and possible duplication:
I would consider splitting the existing test classes so that each of the
new *Command classes has it's own
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/685#discussion_r131479491
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java
---
@@ -34,7 +36,7 @@
public static
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130982335
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
---
@@ -633,8 +631,8 @@ public
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129397800
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,58 @@ public void
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129395826
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,58 @@ public void
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/601#discussion_r124376469
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/GatewayLegacyAuthenticationRegressionTest.java
---
@@ -0,0 +1,429
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/576#discussion_r123578810
--- Diff:
geode-core/src/main/java/org/apache/geode/management/CacheServerMXBean.java ---
@@ -352,44 +352,44 @@
*
* @param clientId ID of
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/582#discussion_r122332971
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
---
@@ -469,15 +470,13 @@ private InternalLocator(int port
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/582#discussion_r122332566
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
---
@@ -2167,7 +2191,7 @@ private static void
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/575#discussion_r121690753
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
---
@@ -39,6 +39,8
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/575#discussion_r121690706
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIOnRegionFunctionExecutionDUnitTest.java
---
@@ -26,7 +26,9
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119419356
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,19 @@ public
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119221757
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public
Github user pdxrunner commented on the issue:
https://github.com/apache/incubator-geode/pull/282
This looks good. I'll pull it in as my first commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
44 matches
Mail list logo
