Re: [DISCUSS] Change signature of Serializable::fromData on Geode-Native

2017-09-14 Thread Michael William Dodge
+1 for the void return type > On 14 Sep, 2017, at 13:39, Ernest Burghardt wrote: > > +1 cleans up the public API and code using this as you can see in the > proposed changes on Jake's fork > > On Wed, Sep 13, 2017 at 3:30 PM, Jacob Barrett

Re: [DISCUSS] Change signature of Serializable::fromData on Geode-Native

2017-09-14 Thread Ernest Burghardt
+1 cleans up the public API and code using this as you can see in the proposed changes on Jake's fork On Wed, Sep 13, 2017 at 3:30 PM, Jacob Barrett wrote: > I would like to propose a change: > Serializable* Serializable::formData(DataInput& in) > to > void

[DISCUSS] Change signature of Serializable::fromData on Geode-Native

2017-09-13 Thread Jacob Barrett
I would like to propose a change: Serializable* Serializable::formData(DataInput& in) to void Serializable::formData(DataInput& in) The current signature allows the object being deserialized to return an object other than itself. The use of this trick is only done internally for a few internal