Re: [DISCUSS] Move TcpServer and friends to new geode-tcp-server module

2019-11-25 Thread Bill Burcham
Thanks for the feedback. We have rough consensus for the new module so we will make it so. On Mon, Nov 18, 2019 at 5:34 PM Joris Melchior wrote: > +1 > > On Mon, Nov 18, 2019 at 6:22 PM Owen Nichols wrote: > > > +1 > > > > > On Nov 18, 2019, at 3:00 PM, Nabarun Nag wrote: > > > > > > +1 > > >

Re: [DISCUSS] Move TcpServer and friends to new geode-tcp-server module

2019-11-18 Thread Joris Melchior
+1 On Mon, Nov 18, 2019 at 6:22 PM Owen Nichols wrote: > +1 > > > On Nov 18, 2019, at 3:00 PM, Nabarun Nag wrote: > > > > +1 > > > > On Mon, Nov 18, 2019 at 2:21 PM Udo Kohlmeyer wrote: > > > >> Thank you for this Bill, > >> > >> I must admit that I'm starting to get a feeling of "scope

Re: [DISCUSS] Move TcpServer and friends to new geode-tcp-server module

2019-11-18 Thread Owen Nichols
+1 > On Nov 18, 2019, at 3:00 PM, Nabarun Nag wrote: > > +1 > > On Mon, Nov 18, 2019 at 2:21 PM Udo Kohlmeyer wrote: > >> Thank you for this Bill, >> >> I must admit that I'm starting to get a feeling of "scope creep" here.. >> I understand that all efforts to "modularize" membership would

Re: [DISCUSS] Move TcpServer and friends to new geode-tcp-server module

2019-11-18 Thread Nabarun Nag
+1 On Mon, Nov 18, 2019 at 2:21 PM Udo Kohlmeyer wrote: > Thank you for this Bill, > > I must admit that I'm starting to get a feeling of "scope creep" here.. > I understand that all efforts to "modularize" membership would require > some form of peripheral decoupling. > > BUT > > I'm starting

Re: [DISCUSS] Move TcpServer and friends to new geode-tcp-server module

2019-11-18 Thread Udo Kohlmeyer
Thank you for this Bill, I must admit that I'm starting to get a feeling of "scope creep" here.. I understand that all efforts to "modularize" membership would require some form of peripheral decoupling. BUT I'm starting to get concerned that we are hitting a rabbit hole scenario. Maybe

Re: [DISCUSS] Move TcpServer and friends to new geode-tcp-server module

2019-11-18 Thread Dan Smith
+1 -Dan On Mon, Nov 18, 2019 at 1:48 PM Bill Burcham wrote: > Dear Geode, > > In support of the Membership modularization efforts > > https://cwiki.apache.org/confluence/display/GEODE/Move+membership+code+to+a+separate+gradle+sub-project > , > we would like to move the types in the >

[DISCUSS] Move TcpServer and friends to new geode-tcp-server module

2019-11-18 Thread Bill Burcham
Dear Geode, In support of the Membership modularization efforts https://cwiki.apache.org/confluence/display/GEODE/Move+membership+code+to+a+separate+gradle+sub-project, we would like to move the types in the org.apache.geode.distributed.internal.tcpserver package (i.e. the TcpServer class and