Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-15 Thread Joris Melchior
Since the feedback has been to proceed with this proposal I will open a JIRA ticket and start the work on this. Thanks for the feedback on this. Joris. On Fri, Jan 3, 2020 at 1:11 PM Kirk Lund wrote: > I'm for un-deprecating it. > > On Fri, Jan 3, 2020 at 7:01 AM Joris Melchior > wrote: > >

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-03 Thread Kirk Lund
I'm for un-deprecating it. On Fri, Jan 3, 2020 at 7:01 AM Joris Melchior wrote: > Yes, the code indicates that the deprecation is related to the different > QueryService methods but then these methods end up using the IndexType > themselves which is the main reason I want to un-deprecate the

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-03 Thread Joris Melchior
Yes, the code indicates that the deprecation is related to the different QueryService methods but then these methods end up using the IndexType themselves which is the main reason I want to un-deprecate the ENUM itself. The changes to the QueryService interface in the proposal were suggested by

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-02 Thread John Blum
I thought I recall that the IndexType [1] was *deprecated* in favor of specific methods on the QueryService

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-02 Thread Joris Melchior
Hi Kirk, No, I've tried to figure that out but was unsuccessful in doing so. It would be helpful if someone would be able to shed some light on that. On Thu, Jan 2, 2020 at 1:34 PM Kirk Lund wrote: > Hi Joris, I've read the proposal and reviewed the code some. It's not clear > to me why it

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-02 Thread Kirk Lund
Hi Joris, I've read the proposal and reviewed the code some. It's not clear to me why it was originally deprecated or what the intended new direction (instead of IndexType) was ever going to be. Do you know more about why it was deprecated or what the devs were going to replace it with? On Thu,

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-02 Thread Joris Melchior
Apart from Bruce's response (thanks!) it's been very quiet on this item. I'll extend the response time to Jan 10. Details at https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=135863477 Thanks, Joris. On Wed, Dec 4, 2019 at 1:03 PM Bruce Schuchardt wrote: > This proposal seems

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2019-12-04 Thread Bruce Schuchardt
This proposal seems reasonable to me On 12/3/19 10:19 AM, Joris Melchior wrote: Ah, that makes sense. I will update! On Tue, Dec 3, 2019 at 12:41 PM Alexander Murmann wrote: Joris, the "to be reviewed by" field is for a target date by which to wrap up the discussion. Do you mind updating

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2019-12-03 Thread Joris Melchior
Ah, that makes sense. I will update! On Tue, Dec 3, 2019 at 12:41 PM Alexander Murmann wrote: > Joris, the "to be reviewed by" field is for a target date by which to wrap > up the discussion. Do you mind updating the field and letting the mailing > list know what timeframe you envision? > >

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2019-12-03 Thread Alexander Murmann
Joris, the "to be reviewed by" field is for a target date by which to wrap up the discussion. Do you mind updating the field and letting the mailing list know what timeframe you envision? Thanks! On Mon, Dec 2, 2019 at 1:41 PM Joris Melchior wrote: > Hi All, > > Looking for feedback on the

[DISCUSSION] De/un-deprecate IndexType ENUM

2019-12-02 Thread Joris Melchior
Hi All, Looking for feedback on the proposal to [un/de]deprecate the IndexType ENUM on Geode. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=135863477 Thanks, Joris. -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to