[Discussion] Native - Should C++ client support wchar_t type?

2017-10-26 Thread David Kimura
While working on removing out parameters, we noticed code that makes assumption that wchar_t is always 16 bits. virtual void PdxInstance::getField(const char* fieldName, wchar_t& value) const = 0; void PdxInstanceImpl::getField(const char* fieldname, wchar_t& value) const { auto dataInput = g

Re: [Discussion] Native - Should C++ client support wchar_t type?

2017-10-26 Thread Jacob Barrett
I think we should get rid of it. There are plenty of discussions out there around C++ strings and how they relate to Unicode. Wide string does not mean Unicode. The general consensus I have seen is to just use char and require UTF-8 encoding. We have lots of confusion in our code around whether

Re: [Discussion] Native - Should C++ client support wchar_t type?

2017-10-27 Thread Michael William Dodge
I think support for wchar_t adds unnecessary complexity and should be removed. Sarge > On 26 Oct, 2017, at 13:05, Jacob Barrett wrote: > > I think we should get rid of it. There are plenty of discussions out there > around C++ strings and how they relate to Unicode. Wide string does not mean

Re: [Discussion] Native - Should C++ client support wchar_t type?

2017-10-27 Thread Ernest Burghardt
+1 for removal On Fri, Oct 27, 2017 at 10:03 AM, Michael William Dodge wrote: > I think support for wchar_t adds unnecessary complexity and should be > removed. > > Sarge > > > On 26 Oct, 2017, at 13:05, Jacob Barrett wrote: > > > > I think we should get rid of it. There are plenty of discussio