Github user mmartell closed the pull request at:
https://github.com/apache/geode-native/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101662122
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1113,12 +1117,11 @@ class TcrMessageHelper {
return NULL_OBJECT;
} else if
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101652960
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -20,6 +20,10 @@
* limitations under the License.
*/
+//#include
--- End diff
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101655637
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1113,12 +1117,11 @@ class TcrMessageHelper {
return NULL_OBJECT;
} else if (!isObj
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101610701
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1114,10 +1116,10 @@ class TcrMessageHelper {
} else if (!isObj) {
// other
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101580799
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1135,7 +1137,7 @@ class TcrMessageHelper {
return EXCEPTION;
} else {
GitHub user mmartell opened a pull request:
https://github.com/apache/geode-native/pull/15
GEODE-2484: Fix snprintf error. Need #include .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmartell/geode-native feature/GEODE-2484
