Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102539038
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
for (int i = 0; i
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102538789
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
$
)
add_dependencies(c
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102532340
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
for (int i = 0; i < PA
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102517638
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
$
)
add_dependencie
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/24
GEODE-2508: Initial work on new approach to generic lib naming.
Keeping the changes to CppCacheLibrary.cpp - did not, yet, find a CMake way
to do it more seamlessly.
You can merge this p
