[GitHub] geode issue #341: GEODE-2306: Update native client BUILDING.md to reflect ch...

2017-01-17 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/341 @pivotal-jbarrett - Here's a jira - https://issues.apache.org/jira/browse/GEODE-2317. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] geode issue #341: GEODE-2306: Update native client BUILDING.md to reflect ch...

2017-01-17 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode/pull/341 @upthewaterspout, Its an easy change. We went for consistency with the CMake community on the explicit variable setting. It is however consistent to have the module "find" the product by

Re: [GitHub] geode issue #341: GEODE-2306: Update native client BUILDING.md to reflect ch...

2017-01-17 Thread Michael William Dodge
It's current in src/ on next-gen-native-client-software-grant. What do you mean by "down to the root directory"? Sarge > On 17 Jan, 2017, at 13:43, pivotal-jbarrett wrote: > > Github user pivotal-jbarrett commented on the issue: > >

[GitHub] geode issue #341: GEODE-2306: Update native client BUILDING.md to reflect ch...

2017-01-17 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode/pull/341 Let's also move the BUILDING.md down to the root directory so it is easier to find. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] geode issue #341: GEODE-2306: Update native client BUILDING.md to reflect ch...

2017-01-17 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode/pull/341 I would suggest a little more detail on the building in windows since the command provided will use NMake and suck for the person building. Include statement about -G generator options.

[GitHub] geode issue #341: GEODE-2306: Update native client BUILDING.md to reflect ch...

2017-01-17 Thread PivotalSarge
Github user PivotalSarge commented on the issue: https://github.com/apache/geode/pull/341 Mark Doxygen as required and fix typo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature