[GitHub] geode issue #663: GEODE-3314: Fix DLockService token leak.

2017-08-01 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/663 @pivotal-amurmann I'd like to write a unit test. @hiteshk25 and I took a stab at it this afternoon but after an hour or two, got lost in mocks and the tangle of DistributedSystem/DistributedMem

[GitHub] geode issue #663: GEODE-3314: Fix DLockService token leak.

2017-07-28 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/663 We probably can write a unit test. In particular, it would be nice if we could test this bug without starting a whole `Cache`. --- If your project is set up for it, you can reply to this email

[GitHub] geode issue #663: GEODE-3314: Fix DLockService token leak.

2017-07-28 Thread pivotal-amurmann
Github user pivotal-amurmann commented on the issue: https://github.com/apache/geode/pull/663 I am sure it would be hard, but could we please write a unit test for the change that was made to `DLockService#unlock`? --- If your project is set up for it, you can reply to this email and