Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129695770
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,54 @@ public void testUnsupport
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129693040
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,54 @@ public void testUnsupport
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129693128
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,54 @@ public void testUnsupport
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129399451
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,58 @@ public void testUnsupport
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129399374
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,58 @@ public void testUnsupport
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129397800
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,58 @@ public void testUnsuppor
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129395826
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,58 @@ public void testUnsuppor
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r122067285
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
---
@@ -228,4 +139,55 @@ void addEvaluatedSortCriteria(Objec
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r122066276
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
---
@@ -228,4 +139,55 @@ void addEvaluatedSortCriteria(
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r122055572
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
---
@@ -45,78 +44,50 @@ public OrderByComparator(List
order
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r122053903
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
---
@@ -45,78 +44,50 @@ public OrderByComparator(List
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/580
GEODE-2936: Refactoring OrderByComparator
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-2936)
`OrderByComparator.java` contained a lot of redundant and confusing
13 matches
Mail list logo
