[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123832520 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java --- @@ -109,12 +107,10 @@ public Result

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123832527 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java --- @@ -130,31 +125,8 @@ public Result

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123830383 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBean.java --- @@ -148,7 +148,12 @@ public long

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123829882 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java --- @@ -57,7 +56,48 @@ public

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123822645 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java --- @@ -130,31 +125,8 @@ public Result

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123820699 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java --- @@ -109,12 +107,10 @@ public Result

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123819260 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBean.java --- @@ -148,7 +148,12 @@ public long

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123818520 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java --- @@ -57,7 +56,48 @@ public

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123817037 --- Diff: geode-core/src/main/java/org/apache/geode/management/CacheServerMXBean.java --- @@ -60,48 +61,48 @@ /** * Returns the port on

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-21 Thread PurelyApplied
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/596 GEODE-2920 - GEODE-2925: Finer Grained Security Due to the size of this commit and for your convenience of review, I have not yet squashed my commits. Do note that I have not individually