[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/657 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-27 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129961462 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-27 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129961225 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -279,26 +280,29 @@ protected void acceptConnection(Socket sock)

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-27 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129892735 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -279,26 +280,29 @@ protected void acceptConnection(Socket s

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-27 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129879726 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-26 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129689404 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -279,26 +280,29 @@ protected void acceptConnection(Socke

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-26 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129684574 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -279,26 +280,29 @@ protected void acceptConnection(Socket sock)

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-26 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129683975 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-26 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129683563 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -568,6 +568,12 @@ protected Connection(ConnectionTable t, Socket soc

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-26 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129640056 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -279,26 +280,29 @@ protected void acceptConnection(Socket s

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-26 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129639921 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-26 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129640243 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -568,6 +568,12 @@ protected Connection(ConnectionTable t, Socket

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-26 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129645767 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-25 Thread WireBaron
GitHub user WireBaron opened a pull request: https://github.com/apache/geode/pull/657 GEODE-3286: Failing to cleanup connections from ConnectionTable recei… …ver table @kohlmu-pivotal @galen-pivotal @pivotal-amurmann @bschuchardt @hiteshk25 - prevent adding a c