[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/676 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-02 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130987753 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-02 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130928395 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java --- @@ -95,8 +97,8

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-02 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130928974 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-02 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130920986 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-01 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130781436 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java --- @@ -95,8 +97,8 @@

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-01 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130781170 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-01 Thread WireBaron
GitHub user WireBaron opened a pull request: https://github.com/apache/geode/pull/676 GEODE-3321: Adding ErrorCode values to protobuf protocol @pivotal-amurmann @kohlmu-pivotal @hiteshk25 @galen-pivotal @bschuchardt Signed-off-by: Bruce Schuchardt